Patch Detail
Show a patch.
GET /api/patches/23100/?format=api
{ "id": 23100, "url": "https://patchwork.libcamera.org/api/patches/23100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250401141455.492231-1-stanislaw.gruszka@linux.intel.com>", "date": "2025-04-01T14:14:55", "name": "[v2] ipa: simple: Initialize ccmEnabled to false", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b8c9ee33298925f643c42fdbc1cfaa1510e9c688", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23100/mbox/", "series": [ { "id": 5103, "url": "https://patchwork.libcamera.org/api/series/5103/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5103", "date": "2025-04-01T14:14:55", "name": "[v2] ipa: simple: Initialize ccmEnabled to false", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5103/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2385C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Apr 2025 14:15:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A07A668981;\n\tTue, 1 Apr 2025 16:15:28 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24A8468947\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 16:15:25 +0200 (CEST)", "from orviesa001.jf.intel.com ([10.64.159.141])\n\tby orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2025 07:15:00 -0700", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.112.43])\n\tby smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2025 07:14:58 -0700" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"h13SOuu4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743516926; x=1775052926;\n\th=from:to:cc:subject:date:message-id:mime-version:\n\tcontent-transfer-encoding;\n\tbh=HPGhbBEW8KlFkNlFe0+LfcVS4ZQIgloPvZlZnVpS674=;\n\tb=h13SOuu44f6X9aCXOdhZb/fio1ggk6wXTMrmxV2AcgPQmkOe1Ot90gqd\n\tvrnurib6mNM7vWXhGyKjvM//VKvkCS7XP098pg5r5eTMhHj/zRyjn7Bo1\n\tjaf585+G8NSe8Jm8T/WO7xehLV/W0YUXVnQuwQObREx267lCWiRgCUCMn\n\tixveADhd2S41JVn9fIVVXmsTiKX59t9sowk+6ZnqGHiWWn1Jrm3WrJxHF\n\t8R+yMxbzKCIgeaM0ZkZDLTdMqkG5Jdgelppcn1tZWf7cyULhhJhsRcRd/\n\tat//N/XT67g1gYuZX59ix3RRKTbLqbYwRrLXTWnYnKhxuD5RcL0wXxyGJ g==;", "X-CSE-ConnectionGUID": [ "rfg8cRpKSAGHum8J/qANzw==", "zJzLpc0wQJikS2o5cMJmDw==" ], "X-CSE-MsgGUID": [ "EVibgrO0SQmbqFr/QsvwZA==", "/Wa5uHL2R9+6AED9E91N3w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11391\"; a=\"44854980\"", "E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"44854980\"", "E=Sophos;i=\"6.14,293,1736841600\"; d=\"scan'208\";a=\"163625397\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>", "Subject": "[PATCH v2] ipa: simple: Initialize ccmEnabled to false", "Date": "Tue, 1 Apr 2025 16:14:55 +0200", "Message-Id": "<20250401141455.492231-1-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ccmEnabled variable is not initialized by default, which results in\nusage of CCM when the algorithm itself is not enabled and configured.\n\nThe bug manifests itself as seldom reproducible corrupted video stream.\nFix by initialize the variable in IPAContext class initialization list.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nFixes: ac3068655643 (\"libcamera: software_isp: Track whether CCM is enabled\")\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\nv1 -> v2:\n - initialize on declaration \n - fix spelling\n\n src/ipa/simple/ipa_context.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 7dc2cd7ae828..51522720ab98 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -91,7 +91,7 @@ struct IPAContext {\n \tIPAActiveState activeState;\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n-\tbool ccmEnabled;\n+\tbool ccmEnabled = false;\n };\n \n } /* namespace ipa::soft */\n", "prefixes": [ "v2" ] }