Patch Detail
Show a patch.
GET /api/patches/23099/?format=api
{ "id": 23099, "url": "https://patchwork.libcamera.org/api/patches/23099/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23099/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>", "date": "2025-04-01T13:52:57", "name": "[v1] gstreamer: Restore `AeEnable` control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "282f491322aa598f21634ba6f71a84cd4a077ac5", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23099/mbox/", "series": [ { "id": 5102, "url": "https://patchwork.libcamera.org/api/series/5102/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5102", "date": "2025-04-01T13:52:57", "name": "[v1] gstreamer: Restore `AeEnable` control", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5102/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23099/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23099/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 188BBC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Apr 2025 13:53:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E2D76894F;\n\tTue, 1 Apr 2025 15:53:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A98568947\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 15:53:03 +0200 (CEST)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 948E7741\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 15:51:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ekFoCxvm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743515471;\n\tbh=Dfhz9p4vvRrul2N1cstIdvqeP3jydrzDcS6OeawoNlY=;\n\th=From:To:Subject:Date:From;\n\tb=ekFoCxvm0VpAUEruwZIvkNx/AB/mdeQatFOMz2yDIO3BvR1mphPINbH8ss9qGEUob\n\tCIyCsekk+Z/NGvhwHQeDBGf/+k3hKdG/1UtGCGgeOhj6Bo/dh2KVNumcVjlWacAmWv\n\thr291nRAqXHBIPAZI4F1SbBNVVFBGySlplJesuv0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] gstreamer: Restore `AeEnable` control", "Date": "Tue, 1 Apr 2025 15:52:57 +0200", "Message-ID": "<20250401135257.754549-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit \"gstreamer: Generate the new AEGC controls\" removed the\n`AeEnable` control from gen-gst-controls.py. However, the patch\nset it was part of did not end up removing the `AeEnable`\ncontrol after all. So restore it for gstreamer users.\n\nSee 85cb179f289d29 (\"controls: Redefine AeEnable\").\n\nFixes: 187f2d537be5a4 (\"gstreamer: Generate the new AEGC controls\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n utils/codegen/gen-gst-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\nindex 07af7653b..4ca76049e 100755\n--- a/utils/codegen/gen-gst-controls.py\n+++ b/utils/codegen/gen-gst-controls.py\n@@ -19,7 +19,7 @@ from controls import Control\n \n \n exposed_controls = [\n- 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n+ 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n", "prefixes": [ "v1" ] }