Patch Detail
Show a patch.
GET /api/patches/23096/?format=api
{ "id": 23096, "url": "https://patchwork.libcamera.org/api/patches/23096/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23096/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250401131939.749583-3-barnabas.pocze@ideasonboard.com>", "date": "2025-04-01T13:19:37", "name": "[v1,2/4] libcamera: controls: Strings are arrays", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1090c2f667cdb1e72bad16de48820df1b0ca5bf6", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23096/mbox/", "series": [ { "id": 5101, "url": "https://patchwork.libcamera.org/api/series/5101/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5101", "date": "2025-04-01T13:19:35", "name": "libcamera: controls: Misc. changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5101/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23096/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23096/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AEA1C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Apr 2025 13:19:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A6866898C;\n\tTue, 1 Apr 2025 15:19:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8306868985\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 15:19:43 +0200 (CEST)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FC7711E5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 15:17:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kYrtYFQQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743513471;\n\tbh=mUACM1k8JoR3GDdhUrFhVxEaecE81fIzsc0GzYV/FuI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=kYrtYFQQxITKgZp2shEXMOEAxagT7gQYjTsMJZ2arBVPX2ZmEMYgsaHluLQCxd48C\n\t6ADeAQms/WZe5pP/muukV30PI6oC1J8E5EUdE/ujzqN/LnJqyA2BXwqDMY74vQqaVj\n\tJAUt5aaCphBYPSpFuTrVXLoeyAUW/niKA30HP06w=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/4] libcamera: controls: Strings are arrays", "Date": "Tue, 1 Apr 2025 15:19:37 +0200", "Message-ID": "<20250401131939.749583-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250401131939.749583-1-barnabas.pocze@ideasonboard.com>", "References": "<20250401131939.749583-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`ControlId::isArray()` and `ControlValue::isArray()` disagree\nin the case of strings. Fix it by setting the static size of a\nstring to `libcamera::dynamic_extent` to denote a dynamically\nsized array-like value.\n\nOne unfortunate side effect of this change is that if there were\nstring controls (there are none at the moment), then `cam` would\ndisplay them with an extra `Size: n` annotation.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=255\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/controls.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex c1919d864..d35347f4c 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -98,7 +98,7 @@ struct control_type<float> {\n template<>\n struct control_type<std::string> {\n \tstatic constexpr ControlType value = ControlTypeString;\n-\tstatic constexpr std::size_t size = 0;\n+\tstatic constexpr std::size_t size = libcamera::dynamic_extent;\n };\n \n template<>\n", "prefixes": [ "v1", "2/4" ] }