Patch Detail
Show a patch.
GET /api/patches/23088/?format=api
{ "id": 23088, "url": "https://patchwork.libcamera.org/api/patches/23088/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23088/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250401123633.58887-2-stefan.klug@ideasonboard.com>", "date": "2025-04-01T12:36:09", "name": "[v2,1/5] test: ipa: libipa: Add histogram tests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a05e2bb5e45ac338d01431d9cbc13a0e98839bdf", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23088/mbox/", "series": [ { "id": 5099, "url": "https://patchwork.libcamera.org/api/series/5099/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5099", "date": "2025-04-01T12:36:08", "name": "Fix histogram for some (corner) cases", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5099/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23088/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23088/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56E3DC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Apr 2025 12:36:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1302F68987;\n\tTue, 1 Apr 2025 14:36:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9E906894F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 14:36:40 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:14c7:4fcc:495b:719f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C97738DB;\n\tTue, 1 Apr 2025 14:34:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n2smA14J\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743510888;\n\tbh=gy7FIKZqYC9JBLNTVCju94reupfL8FANNuHlDHB4j0U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n2smA14JlvD5SGhCNNmPeHFsnQQOag+ZuUMtI7xshWUGRpOCL4N68Yb5/c7AFd7XU\n\tZ2laO/F/GF70oFnbDTEIzX8Qm7fW6/T7DO9V7De2iGLrnuavtTdi/XovB1Fv6QJWIs\n\tAZp9vQTkxsqKmNvXhARqvnoGArRBAIAS2o95mer8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 1/5] test: ipa: libipa: Add histogram tests", "Date": "Tue, 1 Apr 2025 14:36:09 +0200", "Message-ID": "<20250401123633.58887-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250401123633.58887-1-stefan.klug@ideasonboard.com>", "References": "<20250401123633.58887-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add some basic tests for the histogram class.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Replaced printf by std::cout\n- Collected tags\n---\n test/ipa/libipa/histogram.cpp | 53 +++++++++++++++++++++++++++++++++++\n test/ipa/libipa/meson.build | 1 +\n 2 files changed, 54 insertions(+)\n create mode 100644 test/ipa/libipa/histogram.cpp", "diff": "diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\nnew file mode 100644\nindex 000000000000..312b88b0786b\n--- /dev/null\n+++ b/test/ipa/libipa/histogram.cpp\n@@ -0,0 +1,53 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas on Board Oy\n+ *\n+ * Histogram tests\n+ */\n+\n+#include \"../src/ipa/libipa/histogram.h\"\n+\n+#include <cmath>\n+#include <iostream>\n+#include <map>\n+#include <stdint.h>\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+using namespace ipa;\n+\n+#define ASSERT_EQ(a, b) \\\n+\tif (!((a) == (b))) { \\\n+\t\tstd::cout << #a \" != \" #b << std::endl; \\\n+\t\treturn TestFail; \\\n+\t}\n+\n+class HistogramTest : public Test\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tauto hist = Histogram({ { 50, 50 } });\n+\n+\t\tASSERT_EQ(hist.bins(), 2);\n+\t\tASSERT_EQ(hist.total(), 100);\n+\n+\t\tASSERT_EQ(hist.cumulativeFrequency(1.0), 50);\n+\t\tASSERT_EQ(hist.cumulativeFrequency(1.5), 75);\n+\t\tASSERT_EQ(hist.cumulativeFrequency(2.0), 100);\n+\n+\t\tASSERT_EQ(hist.quantile(0.0), 0.0);\n+\t\tASSERT_EQ(hist.quantile(1.0), 2.0);\n+\t\tASSERT_EQ(hist.quantile(0.5), 1.0);\n+\n+\t\tASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);\n+\t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);\n+\t\tASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(HistogramTest)\ndiff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build\nindex eaf4b49a187c..f094c1593f1b 100644\n--- a/test/ipa/libipa/meson.build\n+++ b/test/ipa/libipa/meson.build\n@@ -2,6 +2,7 @@\n \n libipa_test = [\n {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']},\n+ {'name': 'histogram', 'sources': ['histogram.cpp']},\n {'name': 'interpolator', 'sources': ['interpolator.cpp']},\n ]\n \n", "prefixes": [ "v2", "1/5" ] }