Patch Detail
Show a patch.
GET /api/patches/23078/?format=api
{ "id": 23078, "url": "https://patchwork.libcamera.org/api/patches/23078/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23078/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250331144352.736700-6-stefan.klug@ideasonboard.com>", "date": "2025-03-31T14:43:44", "name": "[5/9] ipa: rkisp1: params: Check for empty parameters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "46d23ab2cef0d56620d9ad31a11793c141b22212", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23078/mbox/", "series": [ { "id": 5094, "url": "https://patchwork.libcamera.org/api/series/5094/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5094", "date": "2025-03-31T14:43:39", "name": "Wdr preparations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5094/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23078/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23078/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 532B4C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Mar 2025 14:44:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D576868997;\n\tMon, 31 Mar 2025 16:44:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4602468996\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 16:44:10 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADE8482A;\n\tMon, 31 Mar 2025 16:42:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wklTRsNM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743432138;\n\tbh=p3VpA4HqZpL55WstkrfogSY/GM1IWuRCUoEtY5V387M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wklTRsNMTZ6liEhfZ88J9v0UvDl76rTjEPfLH0aQPtgxr5jqQjbJtpL7RBB5QqWqG\n\tG2SRGTvp/TLkgvAbffUpXZcFat01NrQqrmla4KS1+r3Cxu9bU6ofFixTwB+YeNLUvQ\n\tfuJc6o/ciojfGQ55fLjJoAkrV7+1zBjwILF6Bhlc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 5/9] ipa: rkisp1: params: Check for empty parameters", "Date": "Mon, 31 Mar 2025 16:43:44 +0200", "Message-ID": "<20250331144352.736700-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "References": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add functions to check for empty parameter blocks. Modify the constructor\nso that a parameter block constructed from an empty span stays empty.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/params.cpp | 3 +++\n src/ipa/rkisp1/params.h | 13 +++++++++++++\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\nindex 4c0b051ce65d..b4a889e415fc 100644\n--- a/src/ipa/rkisp1/params.cpp\n+++ b/src/ipa/rkisp1/params.cpp\n@@ -82,6 +82,9 @@ RkISP1ParamsBlockBase::RkISP1ParamsBlockBase(RkISP1Params *params, BlockType typ\n \t\t\t\t\t const Span<uint8_t> &data)\n \t: params_(params), type_(type)\n {\n+\tif (data.empty())\n+\t\treturn;\n+\n \tif (params_->format() == V4L2_META_FMT_RK_ISP1_EXT_PARAMS) {\n \t\theader_ = data.subspan(0, sizeof(rkisp1_ext_params_block_header));\n \t\tdata_ = data.subspan(sizeof(rkisp1_ext_params_block_header));\ndiff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\nindex 40450e34497a..e0aa04ae0f8d 100644\n--- a/src/ipa/rkisp1/params.h\n+++ b/src/ipa/rkisp1/params.h\n@@ -89,6 +89,9 @@ public:\n \n \tvoid setEnabled(bool enabled);\n \n+\tbool isValid() const { return !data_.empty(); }\n+\texplicit operator bool() const { return !data_.empty(); }\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(RkISP1ParamsBlockBase)\n \n@@ -109,6 +112,16 @@ public:\n \t{\n \t}\n \n+\tconst Type *get() const\n+\t{\n+\t\treturn reinterpret_cast<const Type *>(data().data());\n+\t}\n+\n+\tType *get()\n+\t{\n+\t\treturn reinterpret_cast<Type *>(data().data());\n+\t}\n+\n \tconst Type *operator->() const\n \t{\n \t\treturn reinterpret_cast<const Type *>(data().data());\n", "prefixes": [ "5/9" ] }