Patch Detail
Show a patch.
GET /api/patches/23076/?format=api
{ "id": 23076, "url": "https://patchwork.libcamera.org/api/patches/23076/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23076/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250331144352.736700-4-stefan.klug@ideasonboard.com>", "date": "2025-03-31T14:43:42", "name": "[3/9] utils: gen-debug-controls: Improve log output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "af197607eb5a128eba0698da9a340c2d5d77b756", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23076/mbox/", "series": [ { "id": 5094, "url": "https://patchwork.libcamera.org/api/series/5094/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5094", "date": "2025-03-31T14:43:39", "name": "Wdr preparations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5094/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23076/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23076/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25AE4C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Mar 2025 14:44:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C72AC6898F;\n\tMon, 31 Mar 2025 16:44:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B728568981\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 16:44:04 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4766582A;\n\tMon, 31 Mar 2025 16:42:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M2WsQkHT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743432133;\n\tbh=mZZKJKuoq+HObDtzB/3iWNcoxkso2Z5hALdYnv+d7m0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M2WsQkHTpSGK34KO9Rkkzej7MQTw8nCPVRq2J7fkKb7wg7a3DiUGA/HgQxILYGW8t\n\tjr4nt9dNMV81f14d0N6kI0txtXlYebYXTVltcr24YvFvHMNmYdvPUdtOGMA7XkB3rD\n\th2JgydQVDqbptq3Kamr0nF50Tju5VwZYa9Lvjnag=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 3/9] utils: gen-debug-controls: Improve log output", "Date": "Mon, 31 Mar 2025 16:43:42 +0200", "Message-ID": "<20250331144352.736700-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "References": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add log statements for found controls and the file written. This makes\nit easier to understand what happens under the hood.\n\nWhile at it, create nice colored log out put using coloredlogs if\navailable.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/gen-debug-controls.py | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py\nindex ff22b986475e..a1c69bbd8294 100755\n--- a/utils/gen-debug-controls.py\n+++ b/utils/gen-debug-controls.py\n@@ -17,8 +17,13 @@ import sys\n from dataclasses import dataclass\n from pathlib import Path\n \n-logger = logging.getLogger(__name__)\n-logging.basicConfig(level=logging.INFO, format='%(levelname)s: %(message)s')\n+fmt = '%(levelname)s: %(message)s'\n+try:\n+ import coloredlogs\n+ coloredlogs.install(level=logging.INFO, fmt=fmt)\n+except ImportError:\n+ logging.basicConfig(level=logging.INFO, format=fmt)\n+\n \n try:\n import ruamel.yaml as ruyaml\n@@ -27,6 +32,8 @@ except:\n f'Failed to import ruamel.yaml. Please install the ruamel.yaml package.')\n sys.exit(1)\n \n+logger = logging.getLogger(__name__)\n+\n @dataclass\n class FoundMatch:\n file: os.PathLike\n@@ -106,6 +113,7 @@ def main(argv):\n continue\n \n p = m.file.relative_to(root_dir)\n+ logger.info(f\"Found control {m.name} in {p}\")\n desc = {'type': m.type,\n 'direction': 'out',\n 'description': f'Debug control {m.name} found in {p}'}\n@@ -165,6 +173,9 @@ def main(argv):\n \"#\\n\"))\n yaml.dump(doc, f)\n \n+ p = ctrl_file.relative_to(Path.cwd(), walk_up=True)\n+ logger.info(f\"Sucessfully updated {p}\")\n+\n return 0\n \n \n", "prefixes": [ "3/9" ] }