Patch Detail
Show a patch.
GET /api/patches/23063/?format=api
{ "id": 23063, "url": "https://patchwork.libcamera.org/api/patches/23063/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23063/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250327185945.159481-6-mzamazal@redhat.com>", "date": "2025-03-27T18:59:43", "name": "[v6,5/6] ipa: simple: Report contrast in metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "43eb9220432a485897fd42daa3ccc89703aafe85", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23063/mbox/", "series": [ { "id": 5087, "url": "https://patchwork.libcamera.org/api/series/5087/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5087", "date": "2025-03-27T18:59:38", "name": "ipa: simple: Introduce metadata reporting", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5087/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23063/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23063/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03651C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Mar 2025 19:00:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A19968983;\n\tThu, 27 Mar 2025 20:00:13 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 326EE68982\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Mar 2025 20:00:09 +0100 (CET)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-658-OKE-JFT5NGmWxHUGKqXjFA-1;\n\tThu, 27 Mar 2025 15:00:06 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B004618EBE91; Thu, 27 Mar 2025 19:00:05 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.17])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D839E3001D0F; Thu, 27 Mar 2025 19:00:03 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Soxx1SAr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1743102008;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LFGtOZDi6AAxrfHyTW6fpfh0z6nzKONhGFxK3+o8AJA=;\n\tb=Soxx1SArY90lpcjxKagmXoi+bnP4T8i8Ix3lrvB7ZPU2BBmGFSklOiDrpPUtdIQsOgMXnS\n\toLkdDMxhDtorf374P52IdEcxPcP9HoKxNZPNqDzDkHxmzIzum1Q8HY3zYDbsaflBlFYVHG\n\txBTR5BeOK5lDh4a9w6Hrj8N4mj5g9/k=", "X-MC-Unique": "OKE-JFT5NGmWxHUGKqXjFA-1", "X-Mimecast-MFC-AGG-ID": "OKE-JFT5NGmWxHUGKqXjFA_1743102005", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 5/6] ipa: simple: Report contrast in metadata", "Date": "Thu, 27 Mar 2025 19:59:43 +0100", "Message-ID": "<20250327185945.159481-6-mzamazal@redhat.com>", "In-Reply-To": "<20250327185945.159481-1-mzamazal@redhat.com>", "References": "<20250327185945.159481-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "geddwMB-O_cF11uadVF97PxIqexEK8f-KDcKjp9Iszs_1743102005", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the requested contrast value, if any, in the metadata to add to\nthe completed requests.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/lut.cpp | 15 ++++++++++++++-\n src/ipa/simple/algorithms/lut.h | 5 +++++\n src/ipa/simple/ipa_context.h | 1 +\n 3 files changed, 20 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex a06cdeba..e8638f27 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -87,9 +87,11 @@ int16_t Lut::ccmValue(unsigned int i, float ccm) const\n \n void Lut::prepare(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n-\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params)\n {\n+\tframeContext.contrast = context.activeState.knobs.contrast;\n+\n \t/*\n \t * Update the gamma table if needed. This means if black level changes\n \t * and since the black level gets updated only if a lower value is\n@@ -139,6 +141,17 @@ void Lut::prepare(IPAContext &context,\n \t}\n }\n \n+void Lut::process([[maybe_unused]] IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] const SwIspStats *stats,\n+\t\t ControlList &metadata)\n+{\n+\tconst auto &contrast = frameContext.contrast;\n+\tif (contrast)\n+\t\tmetadata.set(controls::Contrast, contrast.value());\n+}\n+\n REGISTER_IPA_ALGORITHM(Lut, \"Lut\")\n \n } /* namespace ipa::soft::algorithms */\ndiff --git a/src/ipa/simple/algorithms/lut.h b/src/ipa/simple/algorithms/lut.h\nindex 77324800..ba8b9021 100644\n--- a/src/ipa/simple/algorithms/lut.h\n+++ b/src/ipa/simple/algorithms/lut.h\n@@ -30,6 +30,11 @@ public:\n \t\t const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params) override;\n+\tvoid process(IPAContext &context,\n+\t\t const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const SwIspStats *stats,\n+\t\t ControlList &metadata) override;\n \n private:\n \tvoid updateGammaTable(IPAContext &context);\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex bfac835b..10d539f5 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -74,6 +74,7 @@ struct IPAFrameContext : public FrameContext {\n \t\tdouble red;\n \t\tdouble blue;\n \t} gains;\n+\tstd::optional<double> contrast;\n };\n \n struct IPAContext {\n", "prefixes": [ "v6", "5/6" ] }