Patch Detail
Show a patch.
GET /api/patches/23057/?format=api
{ "id": 23057, "url": "https://patchwork.libcamera.org/api/patches/23057/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23057/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250326134727.279393-4-stefan.klug@ideasonboard.com>", "date": "2025-03-26T13:47:22", "name": "[v2,3/3] ipa: rksip1: Remove setControls(0) to reduce startup oscillations", "commit_ref": "4adf0e0b1cf9733127591c24c2a6129fda481dd9", "pull_url": null, "state": "accepted", "archived": false, "hash": "6e84d64d3850463cdad6a012249240ed86c2c449", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23057/mbox/", "series": [ { "id": 5086, "url": "https://patchwork.libcamera.org/api/series/5086/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5086", "date": "2025-03-26T13:47:19", "name": "rkisp1: Reduce oscillations on startup", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5086/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23057/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23057/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABBC9C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Mar 2025 13:48:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20ED86896D;\n\tWed, 26 Mar 2025 14:48:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D49468964\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Mar 2025 14:48:09 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b21a:42f4:9f3:1df6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9462799F;\n\tWed, 26 Mar 2025 14:46:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DDpBNUoo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742996781;\n\tbh=vI0X0RDILVuDMCMVsAD/8Clca34G1KZ9jz1acYNE5jw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DDpBNUoo7rD7RHbc6Bgr8/TaeJ3p2LWKpz2ut+ndzKZHeO83GWx7q1ipCUqI/hx15\n\travWxcuPTPOvTA251GBg7cDjxI3IPNEXT44o+mw1hOBt9pyb9tYuzJ13cip5bmiYj6\n\tBoGFIxdF8Z+gGzDYqsxMQgrsUoqXfGJMtnQYw1wo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations", "Date": "Wed, 26 Mar 2025 14:47:22 +0100", "Message-ID": "<20250326134727.279393-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250326134727.279393-1-stefan.klug@ideasonboard.com>", "References": "<20250326134727.279393-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The call to setControls(0) is counter productive. At start() time, no\nrequests were queued and no stats were received. So setControls(0)\naccesses a zeroed frame context and in turn sends 0 as gain, exposure\nand vblank to the pipeline handler and DelayedControls. This leads to\nstrong oscillations on every start of the camera.\n\nA proper fix for handling the startup controls still needs to be done\nand was already started in [1] and [2].\n\nFrom a DelayedControls point of view the call to setControls(0) is also\nunnecessary as DelayedControls treat frame 0 as already being queued in\nafter initialization.\n\nSo it is safe to just remove it and the removal fixes the zero\neffectiveExposureValue discussed in the previous patch for rkisp1.\n\n[1]: https://patchwork.libcamera.org/patch/21708/\n[2]: https://patchwork.libcamera.org/patch/22445/\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n- Added \\todo regarding startup controls\n---\n src/ipa/rkisp1/rkisp1.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex cb487ae53aef..70ce0cba22df 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -211,8 +211,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \n int IPARkISP1::start()\n {\n-\tsetControls(0);\n-\n+\t/* \\todo Properly handle startup controls. */\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "3/3" ] }