Patch Detail
Show a patch.
GET /api/patches/2304/?format=api
{ "id": 2304, "url": "https://patchwork.libcamera.org/api/patches/2304/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2304/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>", "date": "2019-11-08T20:53:53", "name": "[libcamera-devel,v2,08/24] libcamera: controls: Make ControList constructor public", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4ec0ca161bac24337e666ffea16185ef1aab3909", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2304/mbox/", "series": [ { "id": 568, "url": "https://patchwork.libcamera.org/api/series/568/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=568", "date": "2019-11-08T20:53:45", "name": "Control serialization and IPA C API", "version": 2, "mbox": "https://patchwork.libcamera.org/series/568/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2304/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2304/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BA5F61520\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Nov 2019 21:54:25 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFC2871D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Nov 2019 21:54:24 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573246464;\n\tbh=U8IClzdsfFjEIH8l0jtC+GTgMg6JFpnH1Wr0kAPKv20=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=oLQvp+cjHFlXEteUUFvrZlqJCWJ0w8m5wnqiSrAWl4x6tuzCRHIqDmmZkbg+5ToxG\n\tPx5FepcPuzyJW2Ib+PEKpS7ORpBo4AkeFszxL867dPWHp3DZefU0/BVyGh7D/p4Wae\n\tewzXpx0NWxGSUWJA2iS60x0Er4aSlEZzOEFq5ASo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Nov 2019 22:53:53 +0200", "Message-Id": "<20191108205409.18845-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>", "References": "<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 08/24] libcamera: controls: Make\n\tControList constructor public", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 08 Nov 2019 20:54:26 -0000" }, "content": "We need to construct empty ControlList objects to serialization. Make\nthe constructor public.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/controls.h | 1 +\n src/libcamera/controls.cpp | 11 +++++++++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 6bad36cbc369..b35e006bc046 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -188,6 +188,7 @@ private:\n \tusing ControlListMap = std::unordered_map<unsigned int, ControlValue>;\n \n public:\n+\tControlList();\n \tControlList(const ControlIdMap &idmap, ControlValidator *validator = nullptr);\n \tControlList(const ControlInfoMap &info, ControlValidator *validator = nullptr);\n \ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex ae6ca2a7cf7e..178ce3d99bce 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -588,6 +588,17 @@ void ControlInfoMap::generateIdmap()\n * controls.\n */\n \n+/**\n+ * \\brief Construct a ControlList not associated with any object\n+ *\n+ * This constructor is meant to support ControlList serialization and shall not\n+ * be used directly by application.\n+ */\n+ControlList::ControlList()\n+\t: validator_(nullptr), idmap_(nullptr)\n+{\n+}\n+\n /**\n * \\brief Construct a ControlList with an optional control validator\n * \\param[in] idmap The ControlId map for the control list target object\n", "prefixes": [ "libcamera-devel", "v2", "08/24" ] }