Patch Detail
Show a patch.
GET /api/patches/23021/?format=api
{ "id": 23021, "url": "https://patchwork.libcamera.org/api/patches/23021/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23021/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250325180821.1456154-4-barnabas.pocze@ideasonboard.com>", "date": "2025-03-25T18:08:15", "name": "[RFC,v3,3/9] libcamera: process: Use `pid_` member to decide if running", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "167d4ea854b70f5d54bbe725f9c3d8b916ea5499", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23021/mbox/", "series": [ { "id": 5079, "url": "https://patchwork.libcamera.org/api/series/5079/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5079", "date": "2025-03-25T18:08:12", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5079/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23021/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23021/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": [ "parsemail@patchwork.libcamera.org", "kbingham@ideasonboard.com" ], "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23F55C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Mar 2025 19:20:48 +0000 (UTC)", "from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2A88353\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Mar 2025 20:19:00 +0100 (CET)", "from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id KJMRAcrw4mfsuS8A4E0KoQ\n\t(envelope-from <libcamera-devel-bounces@lists.libcamera.org>)\n\tfor <kbingham@ideasonboard.com>; Tue, 25 Mar 2025 19:07:06 +0100", "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid D6784353;\tTue, 25 Mar 2025 19:07:05 +0100 (CET)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0733268964;\n\tTue, 25 Mar 2025 19:08:51 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 661F4600EB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Mar 2025 19:08:44 +0100 (CET)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF98782E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Mar 2025 19:06:56 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742930340;\n\tbh=Bk0LKNGS3OO3AGvVk9f5L3HGSQ7+H2GMRKWV09sYKy0=;\n\th=From:To:Subject:Date:In-Reply-To:References:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tResent-From:Resent-To:From;\n\tb=bL/mrVxa2uJCmh1BvP8qQOQhBh+Sm0ZdVXRS5s9gWpSD/3bSDKCCoGkHIk77t7+KN\n\tFeF/WDYoM+ZtKapemQEbqdv8awxQHSLyOTayWOwaUH7pxCtVHkjSTrgdpxOZRf8xjC\n\txLyhrzBZtbzYJxGnDeg457MjPCUcB4evAFmL3XZo=", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742926017;\n\tbh=JYVrXzg3/6kpyzn1pqSQm7ylA7r/8ZaMlbV173Qo9PM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=q0xWf3ZLw/fcU4dXsXy/f40AatEmLGGQxaaWGmj0IJXch8X/YGoOBDmuccl6Aytgt\n\ttjbAA5KZNVpJv4i32KwUg/que39OxsJlrvTN2olRoJoui7u8hwvTnCTkNWOhmfcjvJ\n\tlkHw8CJtwbsh/6jy5VL0PRdB20PrAwOPERvwwZok=" ], "Authentication-Results": [ "perceval.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.a=rsa-sha256 header.s=mail header.b=q0xWf3ZL; dkim-atps=neutral", "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"q0xWf3ZL\";\tdkim-atps=neutral" ], "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 3/9] libcamera: process: Use `pid_` member to decide\n\tif running", "Date": "Tue, 25 Mar 2025 19:08:15 +0100", "Message-ID": "<20250325180821.1456154-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>", "References": "<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>", "X-TUID": "QYN3u8HQInw6", "Resent-From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Resent-To": "parsemail@patchwork.libcamera.org" }, "content": "Instead of using a separate member variable, use `pid_ > 0` to determine\nif the process is still running. Previously the value of `pid_` was not\nreset to -1 when the process terminated, but since it is only meaningful\nwhile the process is running, reset it to -1 in `Process::died()`.\n\nNeither `pid_` nor `running_` are exposed, so this change has no effect\non the public interface or observable behaviour.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/process.h | 1 -\n src/libcamera/process.cpp | 8 +++-----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex 58e3e41ce..030a1e66e 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -49,7 +49,6 @@ private:\n \tvoid died(int wstatus);\n \n \tpid_t pid_;\n-\tbool running_;\n \tenum ExitStatus exitStatus_;\n \tint exitCode_;\n \ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 567b878d4..aa9e8f519 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -208,7 +208,7 @@ const struct sigaction &ProcessManager::oldsa() const\n */\n \n Process::Process()\n-\t: pid_(-1), running_(false), exitStatus_(NotExited), exitCode_(0)\n+\t: pid_(-1), exitStatus_(NotExited), exitCode_(0)\n {\n }\n \n@@ -240,7 +240,7 @@ int Process::start(const std::string &path,\n {\n \tint ret;\n \n-\tif (running_)\n+\tif (pid_ > 0)\n \t\treturn 0;\n \n \tint childPid = fork();\n@@ -252,8 +252,6 @@ int Process::start(const std::string &path,\n \t\tpid_ = childPid;\n \t\tProcessManager::instance()->registerProcess(this);\n \n-\t\trunning_ = true;\n-\n \t\treturn 0;\n \t} else {\n \t\tif (isolate())\n@@ -327,7 +325,7 @@ int Process::isolate()\n */\n void Process::died(int wstatus)\n {\n-\trunning_ = false;\n+\tpid_ = -1;\n \texitStatus_ = WIFEXITED(wstatus) ? NormalExit : SignalExit;\n \texitCode_ = exitStatus_ == NormalExit ? WEXITSTATUS(wstatus) : -1;\n \n", "prefixes": [ "RFC", "v3", "3/9" ] }