Patch Detail
Show a patch.
GET /api/patches/23002/?format=api
{ "id": 23002, "url": "https://patchwork.libcamera.org/api/patches/23002/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23002/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250324170803.103296-2-stefan.klug@ideasonboard.com>", "date": "2025-03-24T17:07:36", "name": "[1/5] test: ipa: libipa: Add histogram tests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "328b1b979467dc41b61868db97367f4ad1a6e1f1", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23002/mbox/", "series": [ { "id": 5077, "url": "https://patchwork.libcamera.org/api/series/5077/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5077", "date": "2025-03-24T17:07:35", "name": "Fix histogram for some (corner) cases", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5077/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23002/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23002/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9799BC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Mar 2025 17:08:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CD8E68954;\n\tMon, 24 Mar 2025 18:08:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FBB868945\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Mar 2025 18:08:16 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:854:5bc6:b2a7:e242])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D0E7455;\n\tMon, 24 Mar 2025 18:06:29 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C9KU1Mhq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742835989;\n\tbh=xWqkUF4YwfxJrRbwmW1md+m0MlZxkpK3+kTodBpdSKc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=C9KU1MhqVzv5FL1vYTLTnEyxvKq/sb01u8HPdM+qbART+gQuxB6plRdcbxTDffm0M\n\twCnGEP49/d6fgQPx3MdclaMWMeIKQa+swMvp8XU7gNllrC4zUGdDFJssFDm3cpj3n0\n\tJ7WWsasVfUfdU+h803HZVu02ZLmIrE02ZgR+5Ofg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 1/5] test: ipa: libipa: Add histogram tests", "Date": "Mon, 24 Mar 2025 18:07:36 +0100", "Message-ID": "<20250324170803.103296-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250324170803.103296-1-stefan.klug@ideasonboard.com>", "References": "<20250324170803.103296-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add some basic tests for the histogram class.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n test/ipa/libipa/histogram.cpp | 53 +++++++++++++++++++++++++++++++++++\n test/ipa/libipa/meson.build | 1 +\n 2 files changed, 54 insertions(+)\n create mode 100644 test/ipa/libipa/histogram.cpp", "diff": "diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\nnew file mode 100644\nindex 000000000000..220a329e33b3\n--- /dev/null\n+++ b/test/ipa/libipa/histogram.cpp\n@@ -0,0 +1,53 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas on Board Oy\n+ *\n+ * Histogram tests\n+ */\n+\n+#include \"../src/ipa/libipa/histogram.h\"\n+\n+#include <cmath>\n+#include <iostream>\n+#include <map>\n+#include <stdint.h>\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+using namespace ipa;\n+\n+#define ASSERT_EQ(a, b) \\\n+\tif (!((a) == (b))) { \\\n+\t\tprintf(#a \" != \" #b \"\\n\"); \\\n+\t\treturn TestFail; \\\n+\t}\n+\n+class HistogramTest : public Test\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tauto hist = Histogram({ { 50, 50 } });\n+\n+\t\tASSERT_EQ(hist.bins(), 2);\n+\t\tASSERT_EQ(hist.total(), 100);\n+\n+\t\tASSERT_EQ(hist.cumulativeFrequency(1.0), 50);\n+\t\tASSERT_EQ(hist.cumulativeFrequency(1.5), 75);\n+\t\tASSERT_EQ(hist.cumulativeFrequency(2.0), 100);\n+\n+\t\tASSERT_EQ(hist.quantile(0.0), 0.0);\n+\t\tASSERT_EQ(hist.quantile(1.0), 2.0);\n+\t\tASSERT_EQ(hist.quantile(0.5), 1.0);\n+\n+\t\tASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0);\n+\t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5);\n+\t\tASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5);\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(HistogramTest)\ndiff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build\nindex eaf4b49a187c..f094c1593f1b 100644\n--- a/test/ipa/libipa/meson.build\n+++ b/test/ipa/libipa/meson.build\n@@ -2,6 +2,7 @@\n \n libipa_test = [\n {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']},\n+ {'name': 'histogram', 'sources': ['histogram.cpp']},\n {'name': 'interpolator', 'sources': ['interpolator.cpp']},\n ]\n \n", "prefixes": [ "1/5" ] }