Patch Detail
Show a patch.
GET /api/patches/22992/?format=api
{ "id": 22992, "url": "https://patchwork.libcamera.org/api/patches/22992/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22992/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250319161152.63625-15-stefan.klug@ideasonboard.com>", "date": "2025-03-19T16:11:19", "name": "[v2,14/17] ipa: rkisp1: Damp color temperature regulation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1872c969b4415fc36505f64139ce48b348f3ece3", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22992/mbox/", "series": [ { "id": 5071, "url": "https://patchwork.libcamera.org/api/series/5071/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5071", "date": "2025-03-19T16:11:05", "name": "Some rkisp1 awb improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5071/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22992/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22992/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01CF3C32FE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Mar 2025 16:12:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A28C368966;\n\tWed, 19 Mar 2025 17:12:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1061168954\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Mar 2025 17:12:39 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:760:e5ca:4814:99c7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 243E48FA;\n\tWed, 19 Mar 2025 17:10:56 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b1OkpFGy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742400656;\n\tbh=V+XkW0IfwfRCMKPanyqHk8nA3AJV88hvfnsN9o3LBxQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=b1OkpFGyW/wz754mc8z+7dSIoS38gNpfn9O5hY6Qp8ajPyCGGjrWpdtDACZ/pwZiW\n\t50KJlAmCzU3de2xhJenoudQko0xl4+DcG3riSbZ8gN4JIMfeI5loICveu9dlceElLm\n\tBa0TQgR+P28Q+rlyspIom90OqZdOtjhYIJJs9X+A=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 14/17] ipa: rkisp1: Damp color temperature regulation", "Date": "Wed, 19 Mar 2025 17:11:19 +0100", "Message-ID": "<20250319161152.63625-15-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250319161152.63625-1-stefan.klug@ideasonboard.com>", "References": "<20250319161152.63625-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Damp the regulation of the color temperature with the same factor as the\ngains. Not damping the color temperature leads to visible flicker, as\nthe CCM changes too much.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 3 +++\n src/ipa/rkisp1/algorithms/ccm.cpp | 4 ----\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 286d9e3e2018..149c6aa59c8d 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -342,9 +342,12 @@ void Awb::process(IPAContext &context,\n \n \t/* Filter the values to avoid oscillations. */\n \tdouble speed = 0.2;\n+\tdouble ct = estimateCCT(rgbMeans);\n+\tct = ct * speed + activeState.awb.automatic.temperatureK * (1 - speed);\n \tawbResult.gains = awbResult.gains * speed +\n \t\t\t activeState.awb.automatic.gains * (1 - speed);\n \n+\tactiveState.awb.automatic.temperatureK = static_cast<unsigned int>(ct);\n \tactiveState.awb.automatic.gains = awbResult.gains;\n \n \tLOG(RkISP1Awb, Debug)\ndiff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex 303ac3dd2fe2..b7f32f0d5d8a 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -139,10 +139,6 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \t}\n \n \tuint32_t ct = frameContext.awb.temperatureK;\n-\t/*\n-\t * \\todo The colour temperature will likely be noisy, add filtering to\n-\t * avoid updating the CCM matrix all the time.\n-\t */\n \tif (frame > 0 && ct == ct_) {\n \t\tframeContext.ccm.ccm = context.activeState.ccm.automatic;\n \t\treturn;\n", "prefixes": [ "v2", "14/17" ] }