Patch Detail
Show a patch.
GET /api/patches/22938/?format=api
{ "id": 22938, "url": "https://patchwork.libcamera.org/api/patches/22938/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22938/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250305192617.18361-8-mzamazal@redhat.com>", "date": "2025-03-05T19:26:14", "name": "[v3,7/8] libcamera: simple: Don't enforce conversion with an added raw stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "82524b17f01f93c475910b3cf719fbaad6218d7c", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22938/mbox/", "series": [ { "id": 5047, "url": "https://patchwork.libcamera.org/api/series/5047/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5047", "date": "2025-03-05T19:26:07", "name": "Enable raw streams with software ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5047/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22938/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22938/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09F4AC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Mar 2025 19:26:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A91068932;\n\tWed, 5 Mar 2025 20:26:52 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A3D1687DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Mar 2025 20:26:49 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-647-5XO2Tre8PlW9RKfhgoidcQ-1;\n\tWed, 05 Mar 2025 14:26:42 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 42676180025E; Wed, 5 Mar 2025 19:26:41 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.87])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id C6EED180049D; Wed, 5 Mar 2025 19:26:39 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"bVomtkqN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1741202808;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+pN8McLpo/xrCArS8EZWpjXiRkYG9sGufHpLr7IF38s=;\n\tb=bVomtkqNqIObIOHHanq3YMKDJjw5dVdRDAEmo2F2LlRr+qk4x/KrWDTXqpwUHmDhtGZEv9\n\tKuOTbJwe9oXozV8peITOWhyNjCFNDm5NXd1Vp4ly/MYTl+Vt0mYKsOQRfclzQf8rJJpptW\n\tUnWfsWT4KUQ/lEbs+KcVmw+/OIKcutI=", "X-MC-Unique": "5XO2Tre8PlW9RKfhgoidcQ-1", "X-Mimecast-MFC-AGG-ID": "5XO2Tre8PlW9RKfhgoidcQ_1741202801", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 7/8] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream", "Date": "Wed, 5 Mar 2025 20:26:14 +0100", "Message-ID": "<20250305192617.18361-8-mzamazal@redhat.com>", "In-Reply-To": "<20250305192617.18361-1-mzamazal@redhat.com>", "References": "<20250305192617.18361-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "9jsV8Q5TE8GwaSdcWN4bdX6P3d5D_94XYOyJC9pB_QM_1741202801", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a387d34b..5b68d2e0 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1095,7 +1095,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (data_->rawRequested_ ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n", "prefixes": [ "v3", "7/8" ] }