Patch Detail
Show a patch.
GET /api/patches/22904/?format=api
{ "id": 22904, "url": "https://patchwork.libcamera.org/api/patches/22904/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22904/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250303134518.10441-1-laurent.pinchart@ideasonboard.com>", "date": "2025-03-03T13:45:18", "name": "[v2] libcamera: camera_manager: Log info message to report camera creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a94aec6fa9a2062c4c83a1f6df20f8edac01d464", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22904/mbox/", "series": [ { "id": 5032, "url": "https://patchwork.libcamera.org/api/series/5032/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5032", "date": "2025-03-03T13:45:18", "name": "[v2] libcamera: camera_manager: Log info message to report camera creation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5032/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22904/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22904/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BDAABD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Mar 2025 13:45:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FE1268777;\n\tMon, 3 Mar 2025 14:45:42 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCD4968772\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Mar 2025 14:45:39 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F83D2D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Mar 2025 14:44:08 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qZx6BLpK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741009448;\n\tbh=Z0teT6McvMTvm4YeGrJMrjOBG+avVU/tgszAH6bzpKM=;\n\th=From:To:Subject:Date:From;\n\tb=qZx6BLpKqmhtnJKHr2MlbbLQzRdaiO0HLs/fkiJzHm/ZWYZr2qVvyzyxBvpqL0cmE\n\tyeoIrZ6DKef69+mYNUHwLWn586DiQjiphyrNtXo6Z1TUwyJSCOs9qGX0C1cDUGzfOy\n\tA1Mr6E/HOq/vJF12xRb20p9rsud0Rvxv7RNprphM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2] libcamera: camera_manager: Log info message to report\n\tcamera creation", "Date": "Mon, 3 Mar 2025 15:45:18 +0200", "Message-ID": "<20250303134518.10441-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Camera creation is one of the most important events generated by\nlibcamera, but we are completely silent about it. The lack of a log\nmessage makes it more difficult to identify problems and provide\nsupport. Fix it by adding an Info message that reports the camera id and\nits pipeline handler when the camera is added.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Move message to CameraManager class\n---\n src/libcamera/camera_manager.cpp | 4 ++++\n 1 file changed, 4 insertions(+)\n\n\nbase-commit: c0a58b97989f7d529f1469b2c2f8705ff55d3af4\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 87e6717ece91..942a72dcfc96 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera)\n\n \tunsigned int index = cameras_.size() - 1;\n\n+\tLOG(Camera, Info)\n+\t\t<< \"Adding camera '\" << camera->id() << \"' for pipeline handler \"\n+\t\t<< camera->_d()->pipe()->name();\n+\n \t/* Report the addition to the public signal */\n \tCameraManager *const o = LIBCAMERA_O_PTR();\n \to->cameraAdded.emit(cameras_[index]);\n", "prefixes": [ "v2" ] }