Patch Detail
Show a patch.
GET /api/patches/22897/?format=api
{ "id": 22897, "url": "https://patchwork.libcamera.org/api/patches/22897/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22897/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250228125600.3241397-2-stefan.klug@ideasonboard.com>", "date": "2025-02-28T12:55:53", "name": "[1/3] ipa: rkisp1: Add debug log for the sensor controls being set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a178af9d0ad1414671c4df8ad5667944d92fb188", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22897/mbox/", "series": [ { "id": 5029, "url": "https://patchwork.libcamera.org/api/series/5029/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5029", "date": "2025-02-28T12:55:52", "name": "rkisp1: Reduce oscillations on startup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5029/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22897/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22897/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26C84C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Feb 2025 12:56:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF9CD68778;\n\tFri, 28 Feb 2025 13:56:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D78AF68773\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Feb 2025 13:56:08 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:a7e:b81b:5754:579])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65BD2606;\n\tFri, 28 Feb 2025 13:54:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JkQ64A93\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740747279;\n\tbh=ZfQwpR4YgcnBKrll+Dx1CYW9WaEfbVgH0MpFz58T2T8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JkQ64A93K3Stb9MlWqIXwsQxNOqzdkypcYyccb6+nbgKax16pokBvsNzVKhdhYY1s\n\tKsKZqg3u+JVcfuPqTmhpagfVNmBq/0N+koUnogaTZobd2FowulRuiTJy5y2qu1Yjp2\n\th/wYR5nPxDU+VEgnlvJUmJop2qT5uh0iN5k5tXvM=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls being\n\tset", "Date": "Fri, 28 Feb 2025 13:55:53 +0100", "Message-ID": "<20250228125600.3241397-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250228125600.3241397-1-stefan.klug@ideasonboard.com>", "References": "<20250228125600.3241397-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In the algorithms a lot of information get's logged in debug log level,\nbut there is no place where the values sent to the sensor get logged.\nAdd such a log message.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7547d2f274f4..5f1583e8219b 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame)\n \tuint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain);\n \tuint32_t vblank = frameContext.agc.vblank;\n \n+\tLOG(IPARkISP1, Debug) << \"Set controls frame \" << frame\n+\t\t\t << \": exposure \" << exposure\n+\t\t\t << \", gain \" << frameContext.agc.gain\n+\t\t\t << \", vblank \" << vblank;\n+\n \tControlList ctrls(sensorControls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));\n", "prefixes": [ "1/3" ] }