Patch Detail
Show a patch.
GET /api/patches/22863/?format=api
{ "id": 22863, "url": "https://patchwork.libcamera.org/api/patches/22863/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22863/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250225152806.22705-1-mzamazal@redhat.com>", "date": "2025-02-25T15:28:06", "name": "libcamera: formatting: Avoid spaces in for loops without expression", "commit_ref": "33ce463a46c44f874fdbc3e484bee730e7b251a3", "pull_url": null, "state": "accepted", "archived": false, "hash": "832d3f2d9a4f9e9a2f87835a61b1505678d5bc6d", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22863/mbox/", "series": [ { "id": 5020, "url": "https://patchwork.libcamera.org/api/series/5020/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5020", "date": "2025-02-25T15:28:06", "name": "libcamera: formatting: Avoid spaces in for loops without expression", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5020/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22863/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22863/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64E48BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Feb 2025 15:28:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56D9E6871E;\n\tTue, 25 Feb 2025 16:28:18 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF1DC68715\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Feb 2025 16:28:16 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-594-qgxUkfRoNEOz3F_G9ATmAw-1;\n\tTue, 25 Feb 2025 10:28:11 -0500", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id DD6AF180087F; Tue, 25 Feb 2025 15:28:10 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.119])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 54E4119560AA; Tue, 25 Feb 2025 15:28:09 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ePfMUicS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740497295;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=3mU4vw0/wcfdUiX7GF64B2URoYAx6+QKAnUfWjqUjQc=;\n\tb=ePfMUicSzG8Gcr6rrB4TN7dIMLgNWtegd/Vf9x6UU2v5kofNz9T9NAU48p9z3nmfz1F5ik\n\t6Mi9ZgHkiEdJOoJgBPYez0lZbIzWRi7vKtX+4ml29EoX6Q83uG5pb2P3kuYaAzU0nmMkeT\n\tDzBK9ybek3zxRyHKfPEtnX4nR3PcI5Q=", "X-MC-Unique": "qgxUkfRoNEOz3F_G9ATmAw-1", "X-Mimecast-MFC-AGG-ID": "qgxUkfRoNEOz3F_G9ATmAw_1740497291", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH] libcamera: formatting: Avoid spaces in for loops without\n\texpression", "Date": "Tue, 25 Feb 2025 16:28:06 +0100", "Message-ID": "<20250225152806.22705-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "FLzGC54NGzZg_8vfgtMVpY2hNihwDr1lyX6FhZhs5NU_1740497291", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The clang formatter removes spaces in places of empty expressions in for\nloops. For example, it changes\n\n for (init; condition; )\n\nto\n\n for (init; condition;)\n\nlibcamera currently uses both the styles and we should use only one of\nthem for consistency. Since there is apparently no option to override\nthe formatter behavior (see\nhttps://clang.llvm.org/docs/ClangFormatStyleOptions.html), let's remove\nthe extra spaces to make the formatter happy.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/apps/common/options.cpp | 2 +-\n src/apps/qcam/format_converter.cpp | 2 +-\n src/libcamera/base/object.cpp | 2 +-\n src/libcamera/base/signal.cpp | 2 +-\n src/libcamera/base/thread.cpp | 2 +-\n src/libcamera/process.cpp | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/apps/common/options.cpp b/src/apps/common/options.cpp\nindex ece268d0..cae193cc 100644\n--- a/src/apps/common/options.cpp\n+++ b/src/apps/common/options.cpp\n@@ -1040,7 +1040,7 @@ void OptionsParser::usageOptions(const std::list<Option> &options,\n \n \t\tstd::cerr << std::setw(indent) << argument;\n \n-\t\tfor (const char *help = option.help, *end = help; end; ) {\n+\t\tfor (const char *help = option.help, *end = help; end;) {\n \t\t\tend = strchr(help, '\\n');\n \t\t\tif (end) {\n \t\t\t\tstd::cerr << std::string(help, end - help + 1);\ndiff --git a/src/apps/qcam/format_converter.cpp b/src/apps/qcam/format_converter.cpp\nindex 32123493..b025a3c7 100644\n--- a/src/apps/qcam/format_converter.cpp\n+++ b/src/apps/qcam/format_converter.cpp\n@@ -249,7 +249,7 @@ void FormatConverter::convertYUVPacked(const Image *srcImage, unsigned char *dst\n \tdst_stride = width_ * 4;\n \n \tfor (src_y = 0, dst_y = 0; dst_y < height_; src_y++, dst_y++) {\n-\t\tfor (src_x = 0, dst_x = 0; dst_x < width_; ) {\n+\t\tfor (src_x = 0, dst_x = 0; dst_x < width_;) {\n \t\t\tcb = src[src_y * src_stride + src_x * 4 + cb_pos_];\n \t\t\tcr = src[src_y * src_stride + src_x * 4 + cr_pos];\n \ndiff --git a/src/libcamera/base/object.cpp b/src/libcamera/base/object.cpp\nindex 745d2565..37d133cc 100644\n--- a/src/libcamera/base/object.cpp\n+++ b/src/libcamera/base/object.cpp\n@@ -350,7 +350,7 @@ void Object::connect(SignalBase *signal)\n \n void Object::disconnect(SignalBase *signal)\n {\n-\tfor (auto iter = signals_.begin(); iter != signals_.end(); ) {\n+\tfor (auto iter = signals_.begin(); iter != signals_.end();) {\n \t\tif (*iter == signal)\n \t\t\titer = signals_.erase(iter);\n \t\telse\ndiff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\nindex b782e050..7876a21d 100644\n--- a/src/libcamera/base/signal.cpp\n+++ b/src/libcamera/base/signal.cpp\n@@ -49,7 +49,7 @@ void SignalBase::disconnect(std::function<bool(SlotList::iterator &)> match)\n {\n \tMutexLocker locker(signalsLock);\n \n-\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n+\tfor (auto iter = slots_.begin(); iter != slots_.end();) {\n \t\tif (match(iter)) {\n \t\t\tObject *object = (*iter)->object();\n \t\t\tif (object)\ndiff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 319bfda9..646ad3cb 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -657,7 +657,7 @@ void Thread::dispatchMessages(Message::Type type)\n \t * the outer calls.\n \t */\n \tif (!--data_->messages_.recursion_) {\n-\t\tfor (auto iter = messages.begin(); iter != messages.end(); ) {\n+\t\tfor (auto iter = messages.begin(); iter != messages.end();) {\n \t\t\tif (!*iter)\n \t\t\t\titer = messages.erase(iter);\n \t\t\telse\ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex bc9833f4..68fad327 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -75,7 +75,7 @@ void ProcessManager::sighandler()\n \t\treturn;\n \t}\n \n-\tfor (auto it = processes_.begin(); it != processes_.end(); ) {\n+\tfor (auto it = processes_.begin(); it != processes_.end();) {\n \t\tProcess *process = *it;\n \n \t\tint wstatus;\n", "prefixes": [] }