Patch Detail
Show a patch.
GET /api/patches/22837/?format=api
{ "id": 22837, "url": "https://patchwork.libcamera.org/api/patches/22837/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22837/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-16-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:04:03", "name": "[15/15] libcamera: Drop spurious colon after doxygen \\todo directive", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ab1921468daa50075934a85f0acb7afc367bd00f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22837/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22837/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22837/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58E95BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:05:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D1D1686E7;\n\tMon, 24 Feb 2025 00:05:01 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FFF9686DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:42 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A566E353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:03:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fuzn8KJ9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351795;\n\tbh=Xclq0HdpXI5FySBzgwvTOxiIL/YEDzYC29rX0Lw+v2Y=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fuzn8KJ9OWwwiAT61UNZEPfhF5YW0l0OUMgJt9haXaYtZxErWW7jdtExYgDAg/gNi\n\tGBZ0Nq0yZDxwCUm547oAq3d0goNNY+NXw0i6U4Q2DUiupb0/Ay/SMZjJNYNLZCU8Lj\n\tj0kUWs42Mhbm7CtvGgqcfjrFXqct8eFni4lkECtM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 15/15] libcamera: Drop spurious colon after doxygen \\todo\n\tdirective", "Date": "Mon, 24 Feb 2025 01:04:03 +0200", "Message-ID": "<20250223230403.1226-16-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The doxygen \\todo directive doesn't need to be followed by a colon. Drop\nit. While at it, turn one 'todo:' into '\\todo'.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb_bayes.cpp | 5 +++--\n src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-\n 5 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp\nindex d2869610a25b..c3d05e7e3413 100644\n--- a/src/ipa/libipa/awb_bayes.cpp\n+++ b/src/ipa/libipa/awb_bayes.cpp\n@@ -26,7 +26,8 @@\n *\n * This implementation is based on the initial implementation done by\n * RaspberryPi.\n- * \\todo: Documentation\n+ *\n+ * \\todo Documentation\n *\n * \\todo Not all the features implemented by RaspberryPi were ported over to\n * this algorithm because they either rely on hardware features not generally\n@@ -272,7 +273,7 @@ void AwbBayes::handleControls(const ControlList &controls)\n RGB<double> AwbBayes::gainsFromColourTemperature(double colourTemperature)\n {\n \t/*\n-\t * \\todo: In the RaspberryPi code, the ct curve was interpolated in\n+\t * \\todo In the RaspberryPi code, the ct curve was interpolated in\n \t * the white point space (1/x) not in gains space. This feels counter\n \t * intuitive, as the gains are in linear space. But I can't prove it.\n \t */\ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 3c2864fd181c..52b57ab4e3b6 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -176,7 +176,7 @@ void Awb::queueRequest(IPAContext &context,\n \t\tawb.gains.manual.r() = (*colourGains)[0];\n \t\tawb.gains.manual.b() = (*colourGains)[1];\n \t\t/*\n-\t\t * \\todo: Colour temperature reported in metadata is now\n+\t\t * \\todo Colour temperature reported in metadata is now\n \t\t * incorrect, as we can't deduce the temperature from the gains.\n \t\t * This will be fixed with the bayes AWB algorithm.\n \t\t */\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 566f18ced51c..ee05b798fded 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -738,7 +738,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n }\n \n /*\n- * \\todo: This should be extended to include Feature::Flag to denote\n+ * \\todo This should be extended to include Feature::Flag to denote\n * what each converter supports feature-wise.\n */\n static std::initializer_list<std::string> compatibles = {\ndiff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 5abd6b200e83..a05e11fccf8d 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1615,7 +1615,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tisp_->frameStart.connect(data->delayedCtrls_.get(),\n \t\t\t\t\t &DelayedControls::applyControls);\n \n-\t\t/* \\todo: Init properties. */\n+\t\t/* \\todo Init properties. */\n \n \t\tif (!registerMaliCamera(std::move(data), sensor->name()))\n \t\t\treturn false;\ndiff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp\nindex 0cbfe39bf2f0..1e009946d53b 100644\n--- a/src/libcamera/pipeline/virtual/config_parser.cpp\n+++ b/src/libcamera/pipeline/virtual/config_parser.cpp\n@@ -54,7 +54,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)\n \n \t\tdata->config_.id = cameraId;\n \t\tControlInfoMap::Map controls;\n-\t\t/* todo: Check which resolution's frame rate to be reported */\n+\t\t/* \\todo Check which resolution's frame rate to be reported */\n \t\tcontrols[&controls::FrameDurationLimits] =\n \t\t\tControlInfo(1000000 / data->config_.resolutions[0].frameRates[1],\n \t\t\t\t 1000000 / data->config_.resolutions[0].frameRates[0]);\n", "prefixes": [ "15/15" ] }