Patch Detail
Show a patch.
GET /api/patches/22830/?format=api
{ "id": 22830, "url": "https://patchwork.libcamera.org/api/patches/22830/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22830/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-9-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:03:56", "name": "[08/15] libipa: awb: Rename AwbStats::getRGBMeans() to rgbMeans()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5e018135750bcbfbf7c1a9cab765cf2b0de94512", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22830/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22830/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22830/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16D23BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:04:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B6B7686E0;\n\tMon, 24 Feb 2025 00:04:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45A9A686C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:31 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36168353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:03:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ofsPN9ln\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351785;\n\tbh=L9XFMcrCWCCN/hx61fGcLqpx9JIITIUXcRntuBjp2ZQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ofsPN9lnVoJdrN2eo1bYEF73TImkoTXQeD6wjflYmxyKSpiaLBnXOQH8d3/SkkFep\n\tOTJGt12V1Lp0zp9Rxx9BDvCIVfTXIvbFDjp7iXOHp1qKcBccuGVW4AsHw6b5cx1cnC\n\tVuiUaylG04mHfrB8SZRMAGO2HV1a7og2m3jsVc74=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 08/15] libipa: awb: Rename AwbStats::getRGBMeans() to\n\trgbMeans()", "Date": "Mon, 24 Feb 2025 01:03:56 +0200", "Message-ID": "<20250223230403.1226-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The convention in libcamera is not to prefix getters with a 'get'\nprefix. Rename the AwbStats::getRGBMeans() function accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb.cpp | 2 +-\n src/ipa/libipa/awb.h | 2 +-\n src/ipa/libipa/awb_grey.cpp | 2 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\nindex 1c4f2330ec6c..925fac232709 100644\n--- a/src/ipa/libipa/awb.cpp\n+++ b/src/ipa/libipa/awb.cpp\n@@ -65,7 +65,7 @@ namespace ipa {\n */\n \n /**\n- * \\fn AwbStats::getRGBMeans()\n+ * \\fn AwbStats::rgbMeans()\n * \\brief Get RGB means of the statistics\n *\n * Fetch the RGB means from the statistics. The values of each channel are\ndiff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\nindex 5c298d3b6f69..a86581adf43e 100644\n--- a/src/ipa/libipa/awb.h\n+++ b/src/ipa/libipa/awb.h\n@@ -26,7 +26,7 @@ struct AwbResult {\n \n struct AwbStats {\n \tvirtual double computeColourError(const RGB<double> &gains) const = 0;\n-\tvirtual RGB<double> getRGBMeans() const = 0;\n+\tvirtual RGB<double> rgbMeans() const = 0;\n };\n \n class AwbAlgorithm\ndiff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\nindex e979cc4d1a3e..17b8598400e7 100644\n--- a/src/ipa/libipa/awb_grey.cpp\n+++ b/src/ipa/libipa/awb_grey.cpp\n@@ -73,7 +73,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] unsigned int lux)\n {\n \tAwbResult result;\n-\tauto means = stats.getRGBMeans();\n+\tauto means = stats.rgbMeans();\n \tresult.colourTemperature = estimateCCT(means);\n \n \t/*\ndiff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 3d6737df801c..af34b81beb96 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -65,7 +65,7 @@ public:\n \t\treturn delta2;\n \t}\n \n-\tRGB<double> getRGBMeans() const override\n+\tRGB<double> rgbMeans() const override\n \t{\n \t\treturn rgbMeans_;\n \t}\n", "prefixes": [ "08/15" ] }