Patch Detail
Show a patch.
GET /api/patches/22821/?format=api
{ "id": 22821, "url": "https://patchwork.libcamera.org/api/patches/22821/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22821/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250221135836.450451-1-stefan.klug@ideasonboard.com>", "date": "2025-02-21T13:57:02", "name": "libcamera: pipeline: Fix LIBCAMERA_<NAME>_TUNING_FILE handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cfff273a93200ad6538209ba6dcf6b28d0772a96", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22821/mbox/", "series": [ { "id": 5011, "url": "https://patchwork.libcamera.org/api/series/5011/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5011", "date": "2025-02-21T13:57:02", "name": "libcamera: pipeline: Fix LIBCAMERA_<NAME>_TUNING_FILE handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5011/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22821/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22821/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17A9BBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Feb 2025 13:58:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1570B686A7;\n\tFri, 21 Feb 2025 14:58:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 673B261857\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Feb 2025 14:58:42 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4117:4b18:d9c3:804d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA6DD7E0;\n\tFri, 21 Feb 2025 14:57:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ne4gHGx4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740146237;\n\tbh=J0AZsBhALWGroEsHsGW6pHzUReoDlTEJKqLIktrX8Gc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Ne4gHGx4z1Ymg3u6g+wVt1PnyO/9R+HxifEcajL/tnuehS8c2kL2ct1AHpp/M5Jgq\n\tytMyjUSqVtNX+LEh4TOyQ8uqRYwWPCCNyLINvh9Mjue9dymKLlNCVxIZ52HuigxNSf\n\tEY59x7yYwoAi9/B2NHVKwHSCBxoQHn6NuDD/jIdU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] libcamera: pipeline: Fix LIBCAMERA_<NAME>_TUNING_FILE\n\thandling", "Date": "Fri, 21 Feb 2025 14:57:02 +0100", "Message-ID": "<20250221135836.450451-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In f5da05ed03ee (\"libcamera: pipeline: Move tuning file override\nhandling to IPAProxy\") a incorrect comparison slipped through. That\nbroke the handling of LIBCAMERA_<NAME>_TUNING_FILE. Fix that.\n\nFixes: f5da05ed03ee (\"libcamera: pipeline: Move tuning file override handling to IPAProxy\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n\nThis was merged 4 weeks ago. Unbelievable we didn't notice earlier :-/\n\nBest regards,\nStefan\n\n---\n src/libcamera/ipa_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex 25f772a41bf8..9907b9615ec7 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -115,7 +115,7 @@ std::string IPAProxy::configurationFile(const std::string &name,\n \tipaEnvName = \"LIBCAMERA_\" + ipaEnvName + \"_TUNING_FILE\";\n \n \tchar const *configFromEnv = utils::secure_getenv(ipaEnvName.c_str());\n-\tif (configFromEnv && *configFromEnv == '\\0')\n+\tif (configFromEnv && *configFromEnv != '\\0')\n \t\treturn { configFromEnv };\n \n \tstruct stat statbuf;\n", "prefixes": [] }