Patch Detail
Show a patch.
GET /api/patches/22819/?format=api
{ "id": 22819, "url": "https://patchwork.libcamera.org/api/patches/22819/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22819/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250221112610.42402-2-stanislaw.gruszka@linux.intel.com>", "date": "2025-02-21T11:26:09", "name": "[v4,1/2] libcamera: v4l2_device: add frame start event helpers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "8abf1410821edad58fdb8daae07967fe5a227867", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22819/mbox/", "series": [ { "id": 5010, "url": "https://patchwork.libcamera.org/api/series/5010/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5010", "date": "2025-02-21T11:26:08", "name": "libcamera: start frame events changes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5010/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22819/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22819/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D654BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Feb 2025 11:26:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FC17686AC;\n\tFri, 21 Feb 2025 12:26:24 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DE3661857\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Feb 2025 12:26:21 +0100 (CET)", "from fmviesa005.fm.intel.com ([10.60.135.145])\n\tby fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t21 Feb 2025 03:26:19 -0800", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.97.15]) by fmviesa005-auth.fm.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 03:26:17 -0800" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"Pl8LNmVz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1740137182; x=1771673182;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=UW4k0FDkjeG9k7lQqLjmcgK/9CP9EV+BixgUzzq22kE=;\n\tb=Pl8LNmVzff8L6T3IXFTGRCLdAF1OVqvBLj+G6R89GuOZcBSQMh+j2Hb5\n\tjuaf9P6A0IGGwEwTrtpV+epK7R2T5ACwnn0o0zKCC2qpnGAToQWUz+HAh\n\tUDKHnf/YqnK3YDE6NRlAaJjrfupVPKXzsh+yy2NW9KYvHG27UVMxhS/CQ\n\ttz+qjsl2QS+hpLj5i5U8r+nZG2tDVLFt1Ldrvl4Ru9uBBkTPdcjeMDPXg\n\tZhnACEkg8fILxRarZouo7LW4HQg625OXiU4qOGxS2si40O4lcey0DhDiK\n\tGSHiQeo0Srlh/gvJ37zJRLy4QOytgNX87ShNBL86VOq0avIj2ik5QZNr2 Q==;", "X-CSE-ConnectionGUID": [ "YQJiRlP9QjiUPM4HtHemBg==", "UyJi8bGUQUqOGrotsikGHA==" ], "X-CSE-MsgGUID": [ "h6LCZ0xwQ4C6Ro0OWGmBQA==", "m2rOIAt7TBKjKzN+9soF1Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11351\"; a=\"51596199\"", "E=Sophos;i=\"6.13,304,1732608000\"; d=\"scan'208\";a=\"51596199\"", "E=Sophos;i=\"6.13,304,1732608000\"; d=\"scan'208\";a=\"119970879\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tHans de Goede <hdegoede@redhat.com>", "Subject": "[PATCH v4 1/2] libcamera: v4l2_device: add frame start event helpers", "Date": "Fri, 21 Feb 2025 12:26:09 +0100", "Message-Id": "<20250221112610.42402-2-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250221112610.42402-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250221112610.42402-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add helper to check if frame start event are supported by subdevice.\nSince kernel does not have interface to query supported events\nuse subscribe interface.\n\nAdditionally add helper for checking if the event enabled.\nWill be needed later to proper code flow if enabling the event\nfail for some reason.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> # v3\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n include/libcamera/internal/v4l2_device.h | 2 ++\n src/libcamera/v4l2_device.cpp | 25 ++++++++++++++++++++++++\n 2 files changed, 27 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex affe52c2..edbd7c32 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -45,6 +45,8 @@ public:\n \tconst std::string &deviceNode() const { return deviceNode_; }\n \tstd::string devicePath() const;\n \n+\tbool supportsFrameStartEvent();\n+\tbool frameStartEnabled() const { return frameStartEnabled_; }\n \tint setFrameStartEnabled(bool enable);\n \tSignal<uint32_t> frameStart;\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 2f65a43a..ca718897 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -449,6 +449,31 @@ std::string V4L2Device::devicePath() const\n \treturn path;\n }\n \n+/**\n+ * \\brief Check if frame start event is supported\n+ * \\return True if frame start event is supported, false otherwise\n+ */\n+\n+bool V4L2Device::supportsFrameStartEvent()\n+{\n+\tstruct v4l2_event_subscription event {\n+\t};\n+\tevent.type = V4L2_EVENT_FRAME_SYNC;\n+\n+\tint ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);\n+\tif (ret)\n+\t\treturn false;\n+\n+\tioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);\n+\treturn true;\n+}\n+\n+/**\n+ * \\fn V4L2Device::frameStartEnabled()\n+ * \\brief Check if frame start event is enabled\n+ * \\return True if frame start event is enabled, false otherwise\n+ */\n+\n /**\n * \\brief Enable or disable frame start event notification\n * \\param[in] enable True to enable frame start events, false to disable them\n", "prefixes": [ "v4", "1/2" ] }