Patch Detail
Show a patch.
GET /api/patches/22808/?format=api
{ "id": 22808, "url": "https://patchwork.libcamera.org/api/patches/22808/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22808/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217185433.306833-9-pobrn@protonmail.com>", "date": "2025-02-17T18:55:10", "name": "[v3,8/8] libcamera: base: log: Avoid manual `LogCategory` deletion", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "443683ec1a533785638189f9757e4507f0e9516e", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22808/mbox/", "series": [ { "id": 5007, "url": "https://patchwork.libcamera.org/api/series/5007/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5007", "date": "2025-02-17T18:54:35", "name": "libcamera: base: log: Misc. changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5007/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22808/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22808/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CC13C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 18:55:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A955468698;\n\tMon, 17 Feb 2025 19:55:15 +0100 (CET)", "from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98DF368697\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 19:55:12 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"WMewOK2l\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1739818512; x=1740077712;\n\tbh=IKmqx1SXJwpufJa0slW3yC48eFAvkOWt4qFhcYH/H+g=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=WMewOK2lrcwyfaC6Q0wOX92dmRLGt93KxjOHnmySye0Z/kGdEQN+2RJouFjoXIdg/\n\tjxuslklxlcQQaqAlXa5BClHr9DNIarxk6Q02EM2PYHfoKe8+Wtb1KEfKZsWclcipZD\n\tq6r4WY1px3hlnI5/yi3P5R9o3uFExu4IEXOAFVpha0Lgjh9nfXTGl9AQ2RZSdcgg3J\n\tWnsgE5GD4JE9qt+Qo8r8w9nZXWD8/jUdtHj74ptDE0fD7K6vUUP4lv+KYMd3248dgg\n\tmMnqk39qxNAwgPIKwa8A5I/lxv2xXblzlk/hMJAVObXUWg2ohKLrc56ucbp+E/vWyF\n\t25ddKoox9Zx9A==", "Date": "Mon, 17 Feb 2025 18:55:10 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v3 8/8] libcamera: base: log: Avoid manual `LogCategory`\n\tdeletion", "Message-ID": "<20250217185433.306833-9-pobrn@protonmail.com>", "In-Reply-To": "<20250217185433.306833-1-pobrn@protonmail.com>", "References": "<20250217185433.306833-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "56ff5397914f1c91dccec090acdcd645003fd2c7", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Wrap the `LogCategory` pointers in `std::unique_ptr` to avoid\nthe need for manual deletion in the destructor.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/libcamera/base/log.cpp | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex fd6c11716..e05ffc1c4 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -322,7 +322,7 @@ private:\n \tstatic bool destroyed_;\n \n \tMutex mutex_;\n-\tstd::vector<LogCategory *> categories_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n+\tstd::vector<std::unique_ptr<LogCategory>> categories_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tstd::list<std::pair<std::string, LogSeverity>> levels_;\n \n \tstd::atomic<std::shared_ptr<LogOutput>> output_;\n@@ -439,9 +439,6 @@ void logSetLevel(const char *category, const char *level)\n Logger::~Logger()\n {\n \tdestroyed_ = true;\n-\n-\tfor (LogCategory *category : categories_)\n-\t\tdelete category;\n }\n \n /**\n@@ -574,7 +571,7 @@ void Logger::logSetLevel(const char *category, const char *level)\n \n \tMutexLocker locker(mutex_);\n \n-\tfor (LogCategory *c : categories_) {\n+\tfor (const auto &c : categories_) {\n \t\tif (c->name() == category) {\n \t\t\tc->setSeverity(severity);\n \t\t\tbreak;\n@@ -718,12 +715,12 @@ LogCategory *Logger::findOrCreateCategory(std::string_view name)\n {\n \tMutexLocker locker(mutex_);\n \n-\tfor (LogCategory *category : categories_) {\n+\tfor (const auto &category : categories_) {\n \t\tif (category->name() == name)\n-\t\t\treturn category;\n+\t\t\treturn category.get();\n \t}\n \n-\tLogCategory *category = categories_.emplace_back(new LogCategory(name));\n+\tLogCategory *category = categories_.emplace_back(std::unique_ptr<LogCategory>(new LogCategory(name))).get();\n \tconst char *name_cstr = category->name().c_str();\n \n \tfor (const auto &[pattern, severity] : levels_) {\n", "prefixes": [ "v3", "8/8" ] }