Patch Detail
Show a patch.
GET /api/patches/22802/?format=api
{ "id": 22802, "url": "https://patchwork.libcamera.org/api/patches/22802/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22802/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217185433.306833-3-pobrn@protonmail.com>", "date": "2025-02-17T18:54:45", "name": "[v3,2/8] libcamera: base: log: Use `std::from_chars()`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "233928e1aa8ded0d428b00d420fb074d72ddf1ed", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22802/mbox/", "series": [ { "id": 5007, "url": "https://patchwork.libcamera.org/api/series/5007/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5007", "date": "2025-02-17T18:54:35", "name": "libcamera: base: log: Misc. changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5007/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22802/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22802/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9A8EC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 18:54:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7286668686;\n\tMon, 17 Feb 2025 19:54:51 +0100 (CET)", "from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A4D56867F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 19:54:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"erP1GLnY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1739818489; x=1740077689;\n\tbh=PYr8O0x9BteBWkfQs3r5XTedGHlewmyEL4aOauG2Ju8=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=erP1GLnYqknhVZHG4cm+Asok0Pvzzf1U+5l5Tt/4EoGMC7GEO1DNaT2EtSi6cHWUf\n\tJF2VDnHDHgVZgdUPlvSHzx/2gJJm6aqua4oNt3rHbbP1FheBPI2hAzTFYuzczOZFiB\n\t8yV4sO4tgZascan6QPn9HOWiNGpOylFXgiPkPZAeENUCFgr8yGPKiTLU/pBMWp7+io\n\tyRRQ6j56SQE0Q4i2tlxZBVat5/tkWYcj3R8B3PRqhPx3O7y5J6fp1oK7p5d83bDG+q\n\tFI5a1AXg+3AU8s9Bhn6JKTdAXSVhEgjsnndSie9Piq/XWA5AThiPSI3ai+UskWwFZi\n\t/uWd00soay1nA==", "Date": "Mon, 17 Feb 2025 18:54:45 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 2/8] libcamera: base: log: Use `std::from_chars()`", "Message-ID": "<20250217185433.306833-3-pobrn@protonmail.com>", "In-Reply-To": "<20250217185433.306833-1-pobrn@protonmail.com>", "References": "<20250217185433.306833-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "a9381b72093bdc970382c6f3f22dfb8228ea5d5f", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the `std::from_chars()` function from `<charconv>` to\nparse the integral log level instead of `strtoul` as it\nprovides an easier to use interface and better type safety.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/base/log.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 8c72a005d..3dea1e178 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -8,6 +8,7 @@\n #include <libcamera/base/log.h>\n \n #include <array>\n+#include <charconv>\n #include <fnmatch.h>\n #include <fstream>\n #include <iostream>\n@@ -686,12 +687,11 @@ LogSeverity Logger::parseLogLevel(const std::string &level)\n \t\t\"FATAL\",\n \t};\n \n-\tint severity;\n+\tunsigned int severity;\n \n \tif (std::isdigit(level[0])) {\n-\t\tchar *endptr;\n-\t\tseverity = strtoul(level.c_str(), &endptr, 10);\n-\t\tif (*endptr != '\\0' || severity > LogFatal)\n+\t\tauto [end, ec] = std::from_chars(level.data(), level.data() + level.size(), severity);\n+\t\tif (ec != std::errc() || *end != '\\0' || severity > LogFatal)\n \t\t\tseverity = LogInvalid;\n \t} else {\n \t\tseverity = LogInvalid;\n", "prefixes": [ "v3", "2/8" ] }