Patch Detail
Show a patch.
GET /api/patches/22778/?format=api
{ "id": 22778, "url": "https://patchwork.libcamera.org/api/patches/22778/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22778/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250213085825.228191-1-naush@raspberrypi.com>", "date": "2025-02-13T08:58:21", "name": "[v1] ipa: rpi: Fix incorrect cast for ExposureTime ControlInfo", "commit_ref": "2e8b6fd2178e199049c47b5f8f929f3d53f95362", "pull_url": null, "state": "accepted", "archived": false, "hash": "b9c517777ca796e9a09fd13523f9d55419b65c38", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22778/mbox/", "series": [ { "id": 5000, "url": "https://patchwork.libcamera.org/api/series/5000/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5000", "date": "2025-02-13T08:58:21", "name": "[v1] ipa: rpi: Fix incorrect cast for ExposureTime ControlInfo", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5000/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22778/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22778/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96880BD7D8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Feb 2025 08:58:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70F4B68634;\n\tThu, 13 Feb 2025 09:58:33 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5344D61862\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2025 09:58:31 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-43945a9085dso190665e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2025 00:58:31 -0800 (PST)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-439617fdad3sm11185885e9.10.2025.02.13.00.58.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 13 Feb 2025 00:58:29 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mNEYbXxr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1739437110; x=1740041910;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=j0oPc1hdaT3zJlfUjKGSzdzGsFl/iaR2vT3AbwKNM4Y=;\n\tb=mNEYbXxr/YUOeZQ4Qwo0JR/DN+YwrDHjDSBb0XFi8W9z/LNLfrQVHLhmDEYYI68rfp\n\t0WNYRB8k3/Jq/Avq+4eov7me0qmOvIFke0Q7YEMT3WnbIIp2oCcgXyIrr3uy6yYFb4lW\n\tmD97EXLxsMCj1/QPJjaCmEkDlC0+81BwSXlI+/kPi1KMf5RjFQ6kPURwjqyBXekJfYqw\n\tbeqhcl79ed5mCbgc82ty7XgODW0ev1bu1+1UWOOeqUMp4Rv+aKuCnH6kSjapuPusJKLW\n\tndo8ann+EZO547uDlecWtiTcGj8e9kKY/lML7kmKuEf/iuOud3yLMnBLZ2HQNwaQ8lQ6\n\tza3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1739437110; x=1740041910;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=j0oPc1hdaT3zJlfUjKGSzdzGsFl/iaR2vT3AbwKNM4Y=;\n\tb=q1oSvw8d8ybnAHcpk8PBS7hTgLTSjX/8C1kIL12ILBwMa4Ffdbo6jax+n3ACH5oNL/\n\tiTqa21MwatNHqTxKmdqzfyj7bqvHUUTfNUZuyJQa+G5GZgPOqaXAbrFthoA/dVd2iTOl\n\t4LnArfEzsnsW146RwWeHqvp2uAYYwdNha7jtmxSm5jo0LUjFX/MIezmSruYXeZiY5PJS\n\tFW29EE60blgXOK9rYomIiH+J4gyYKBiTx0LxJySV6y2uRWKYytpee92Yu/Sax41+gDzY\n\t265e+xi5zCxLtKatFLLCm2zRqqb9cWSvxYm42LjszGytEeiOjJVzCjndNj+4E97eo/vD\n\t4eFQ==", "X-Gm-Message-State": "AOJu0Yz5VugpJvdENHkdMGI4wa/2vhYehIdWW5/RBj6yG70PICTJLl4j\n\tShVThXi4EJKsY+F9Ts3tMf1ku5gZt7jVLIRmSg2Dy6IKxb6zKtu6czVlhoqfomY9DVCcIOxIKB+\n\t3J9U=", "X-Gm-Gg": "ASbGncs5MiSmcsPgBWOahphM5AGf5ukBQJx8fBFp3o4yVi6mcQN4GTwmZypsagNXDYZ\n\tyev52GH6q7kcISuNMXb0WHfUuhPTattdwhr+YaY0OK87QQ0jsdp7r+3ewHqZ3bGdAu7pX4hGCP5\n\t8Si/zsTGxdouDUrkXZtbZ4aJ42xqLm30Yplnws3nYxJR9zSU9OJrc+VLSom/KNGqVcNbsLTIG9B\n\tg8fHcLLJj4LbW6/PjaVu4oUvDy1vv8uoawZ+AliMjb8Qwvavp4tacpLjoZTvpW/XMt0lEDN10+a\n\tF03i+k/IZF9F43cAraIf/HfImzod9jKVnfc=", "X-Google-Smtp-Source": "AGHT+IEMHNbOgeM+dV+NCd6tNqC/mSIZANmv02VrNxLCCGRBLMkjAO3jcBLknzKQttAgfA0rvvdqEQ==", "X-Received": "by 2002:a05:600c:6a04:b0:439:5b36:7082 with SMTP id\n\t5b1f17b1804b1-4395b367331mr21489975e9.2.1739437110286; \n\tThu, 13 Feb 2025 00:58:30 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime ControlInfo", "Date": "Thu, 13 Feb 2025 08:58:21 +0000", "Message-ID": "<20250213085825.228191-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "controls::ExposureTime is of type ControlTypeInteger32, but the\ndefault ControlInfoMap casts a value to int64_t causing incorrect\ninitialisation of the associated ControlInfo.\n\nFix this by casting correctly to int32_t.\n\nFixes: bea2db5e (\"ipa: rpi: Apply default ControlInfo values for sensor controls\")\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex d5948c4a1ef4..6734c32ed1b1 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -62,7 +62,7 @@ const ControlInfoMap::Map ipaControls{\n \t\t static_cast<int32_t>(controls::ExposureTimeModeManual),\n \t\t static_cast<int32_t>(controls::ExposureTimeModeAuto)) },\n \t{ &controls::ExposureTime,\n-\t ControlInfo(1, 66666, static_cast<int64_t>(defaultExposureTime.get<std::micro>())) },\n+\t ControlInfo(1, 66666, static_cast<int32_t>(defaultExposureTime.get<std::micro>())) },\n \t{ &controls::AnalogueGainMode,\n \t ControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto),\n \t\t static_cast<int32_t>(controls::AnalogueGainModeManual),\n", "prefixes": [ "v1" ] }