Patch Detail
Show a patch.
GET /api/patches/22765/?format=api
{ "id": 22765, "url": "https://patchwork.libcamera.org/api/patches/22765/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22765/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250207101703.21149-4-mzamazal@redhat.com>", "date": "2025-02-07T10:16:55", "name": "[v7,03/10] libcamera: software_isp: Store color temperature to metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b460dca2f1f60a94fa394ad2f76cbd3fe3df8d8c", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22765/mbox/", "series": [ { "id": 4994, "url": "https://patchwork.libcamera.org/api/series/4994/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4994", "date": "2025-02-07T10:16:52", "name": "Software ISP support for CCM", "version": 7, "mbox": "https://patchwork.libcamera.org/series/4994/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22765/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22765/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97ACCC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 7 Feb 2025 10:17:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FDEB6860F;\n\tFri, 7 Feb 2025 11:17:25 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C2216860A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 Feb 2025 11:17:22 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-556-ixlZQfe2N3uoU3uxaq8zbQ-1;\n\tFri, 07 Feb 2025 05:17:20 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 45DD01800875; Fri, 7 Feb 2025 10:17:19 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.226.123])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id CF43119560AE; Fri, 7 Feb 2025 10:17:16 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WIUDkL/5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738923441;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=7WasbHSFXCV5sy4Y5cLOqvWD35Ya4BxdbgR96cMVhi4=;\n\tb=WIUDkL/5kE3zohrr8V80M859ZpRIXxwLkzdeudgxb9d+sNJi5ATdXNVO6b2hLtLS3l+whb\n\tB4XX22E9phZIQdrwp8cM3vp00yZUP/CR4X7NFdSr53/VoH8zI/km4B105skDNpE36Xq0B+\n\twlIYDHVLh/d7QUj8/FsiMzqNQ7HmKcM=", "X-MC-Unique": "ixlZQfe2N3uoU3uxaq8zbQ-1", "X-Mimecast-MFC-AGG-ID": "ixlZQfe2N3uoU3uxaq8zbQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v7 03/10] libcamera: software_isp: Store color temperature to\n\tmetadata", "Date": "Fri, 7 Feb 2025 11:16:55 +0100", "Message-ID": "<20250207101703.21149-4-mzamazal@redhat.com>", "In-Reply-To": "<20250207101703.21149-1-mzamazal@redhat.com>", "References": "<20250207101703.21149-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "NbvBHz0-Xk2B6ujQEKpx-3BYy_Z9AmBKpHwAOqJlqL0_1738923439", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Image color temperature is a piece of information that should be\nreported in metadata, let's put it there.\n\nMetadata is currently not reported in simple pipeline but we should make\nat least newly added information ready to be reported.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 310be6a7..4e31e386 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -12,6 +12,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libcamera/control_ids.h>\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -34,7 +36,7 @@ void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n-\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n@@ -64,6 +66,7 @@ void Awb::process(IPAContext &context,\n \n \tRGB<double> rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } };\n \tcontext.activeState.awb.temperatureK = estimateCCT(rgbGains);\n+\tmetadata.set(controls::ColourTemperature, context.activeState.awb.temperatureK);\n \n \tLOG(IPASoftAwb, Debug)\n \t\t<< \"gain R/B: \" << gains << \"; temperature: \"\n", "prefixes": [ "v7", "03/10" ] }