Patch Detail
Show a patch.
GET /api/patches/22729/?format=api
{ "id": 22729, "url": "https://patchwork.libcamera.org/api/patches/22729/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22729/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250205212725.138055-2-mzamazal@redhat.com>", "date": "2025-02-05T21:27:13", "name": "[v6,1/1] libcamera: pipeline: virtual: Set `FrameError` on error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4cf7ea091fbcc3b1f92548c318ff03f5b39792f3", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22729/mbox/", "series": [ { "id": 4989, "url": "https://patchwork.libcamera.org/api/series/4989/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4989", "date": "2025-02-05T21:27:12", "name": "Software ISP support for CCM", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4989/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22729/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22729/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78B97C32F2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Feb 2025 21:27:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4694B685D4;\n\tWed, 5 Feb 2025 22:27:43 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56EE8685C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Feb 2025 22:27:41 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-660-lnIhztc3PhaDoJ-WQnL4Bw-1;\n\tWed, 05 Feb 2025 16:27:37 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B6EAC1800875; Wed, 5 Feb 2025 21:27:35 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.28])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2F1421800871; Wed, 5 Feb 2025 21:27:32 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WmTntr2L\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738790860;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=e39xbB09xFZ79lqfzDk33yX3B8VodGckeLJ1adgFWeI=;\n\tb=WmTntr2LwFsNPPOEeyhikpEYaKgm06DPW7ZatN69PP4D8p+rpr3yUDqJdCnUh7HG9JAFDC\n\tOczF3W3F1VVqi3Xyv13oGosAugsxR1xAa+y4mdgJW3FkNUjEHUL5YRwWAOZ/4BZIFvY5rn\n\tY+JWnohmBWmHjcOIR1Dus18JYE/STzc=", "X-MC-Unique": "lnIhztc3PhaDoJ-WQnL4Bw-1", "X-Mimecast-MFC-AGG-ID": "lnIhztc3PhaDoJ-WQnL4Bw", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,\n\tRobert Mader <robert.mader@collabora.com>, Hans de Goede\n\t<hdegoede@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v6 1/1] libcamera: pipeline: virtual: Set `FrameError` on\n\terror", "Date": "Wed, 5 Feb 2025 22:27:13 +0100", "Message-ID": "<20250205212725.138055-2-mzamazal@redhat.com>", "In-Reply-To": "<20250205212725.138055-1-mzamazal@redhat.com>", "References": "<20250205212725.138055-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Vxhtqnzsw0Dk7edG9OQghv4wkQUa9MNX0s7gsLxYNZk_1738790855", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Barnabás Pőcze <pobrn@protonmail.com>\n\nDo not cancel, simply set the buffer's status to `FrameError`\nto notify the user about the error condition.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 82894270..049ebcba 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -322,7 +322,7 @@ int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera,\n \n \t\t\t\tif (streamConfig.frameGenerator->generateFrame(\n \t\t\t\t\t stream->configuration().size, buffer))\n-\t\t\t\t\tbuffer->_d()->cancel();\n+\t\t\t\t\tfmd.status = FrameMetadata::Status::FrameError;\n \n \t\t\t\tcompleteBuffer(request, buffer);\n \t\t\t\tbreak;\n", "prefixes": [ "v6", "1/1" ] }