Patch Detail
Show a patch.
GET /api/patches/22712/?format=api
{ "id": 22712, "url": "https://patchwork.libcamera.org/api/patches/22712/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22712/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130195811.1230581-4-pobrn@protonmail.com>", "date": "2025-01-30T19:58:29", "name": "[RFC,v2,3/9] libcamera: base: log: Remove `LogMessage::init()`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e84cfdd3f0ae979866db1490d7bc55f095c7d41e", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22712/mbox/", "series": [ { "id": 4982, "url": "https://patchwork.libcamera.org/api/series/4982/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4982", "date": "2025-01-30T19:58:14", "name": "libcamera: base: log: Misc. changes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4982/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22712/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22712/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54D6EBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 19:58:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 052466856F;\n\tThu, 30 Jan 2025 20:58:36 +0100 (CET)", "from mail-10631.protonmail.ch (mail-10631.protonmail.ch\n\t[79.135.106.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CADF86851B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 20:58:34 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"m5pQN/lb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738267113; x=1738526313;\n\tbh=oTBK7RJ1NZawKYjOPU9CPCk4DQ19ntVzH0LoVi2ujRc=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=m5pQN/lbczLqul8GlwoGI6NRIRSkomiOFxsmfzJFJYFgMD+grz8byUQ149nHRkmRS\n\tef/IxhPpBxXLwa48d+wP/j02yExwJuX6ghzmCzwfHimDEST8rnMx9gYka/k1rfwSTV\n\tMbQLWYwMdAgMwcEpm3xSGiqI94gHpflar1gYcSLRMYrH4RONlxWpxv5SpBRp8jONwO\n\tdTATfHem0p37YbZdMbLyKNErbZd5llgyeswPkQYXBVe6a5+mGyyDQNsv3QgkkSUSDl\n\tNoxChqkCnELHwiVLUf7PyFAd32JE3nHbioCjrMSHe68JGVyG3+p0Cia2OYMx7eCXzK\n\teDTnQ8nDvS97w==", "Date": "Thu, 30 Jan 2025 19:58:29 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v2 3/9] libcamera: base: log: Remove `LogMessage::init()`", "Message-ID": "<20250130195811.1230581-4-pobrn@protonmail.com>", "In-Reply-To": "<20250130195811.1230581-1-pobrn@protonmail.com>", "References": "<20250130195811.1230581-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "d10034f6c9556a43ba3149076683d15dd6c345b6", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It is a short function that can be merged into the constructor with\nessentially no change in observable behaviour, so do that.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/log.h | 2 --\n src/libcamera/base/log.cpp | 13 +++----------\n 2 files changed, 3 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex b3050eedb..6d2c93019 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -75,8 +75,6 @@ public:\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(LogMessage)\n \n-\tvoid init(const char *fileName, unsigned int line);\n-\n \tstd::ostringstream msgStream_;\n \tconst LogCategory &category_;\n \tLogSeverity severity_;\ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 31053aee1..51a5cd470 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -875,19 +875,12 @@ const LogCategory &LogCategory::defaultCategory()\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n \t\t const std::string &prefix)\n-\t: category_(category), severity_(severity), prefix_(prefix)\n+\t: category_(category), severity_(severity),\n+\t timestamp_(utils::clock::now()), prefix_(prefix)\n {\n-\tinit(fileName, line);\n-}\n-\n-void LogMessage::init(const char *fileName, unsigned int line)\n-{\n-\t/* Log the timestamp, severity and file information. */\n-\ttimestamp_ = utils::clock::now();\n-\n \tstd::ostringstream ossFileInfo;\n \tossFileInfo << utils::basename(fileName) << \":\" << line;\n-\tfileInfo_ = ossFileInfo.str();\n+\tfileInfo_ = std::move(ossFileInfo).str();\n }\n \n LogMessage::~LogMessage()\n", "prefixes": [ "RFC", "v2", "3/9" ] }