Patch Detail
Show a patch.
GET /api/patches/22705/?format=api
{ "id": 22705, "url": "https://patchwork.libcamera.org/api/patches/22705/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22705/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130181449.130492-9-mzamazal@redhat.com>", "date": "2025-01-30T18:14:45", "name": "[v5,08/10] libcamera: software_isp: Add an example CCM to uncalibrated.yaml", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ebfc585e57169ccc39944c6a42e54db47044eca2", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22705/mbox/", "series": [ { "id": 4980, "url": "https://patchwork.libcamera.org/api/series/4980/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4980", "date": "2025-01-30T18:14:37", "name": "Software ISP support for CCM", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4980/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22705/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22705/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 441A3BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 18:15:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F071F6857B;\n\tThu, 30 Jan 2025 19:15:33 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79BFA6856B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 19:15:32 +0100 (CET)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-669-5MI7k_16OH6o9zN76IhlMQ-1;\n\tThu, 30 Jan 2025 13:15:27 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 1C7C119560B3; Thu, 30 Jan 2025 18:15:26 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id CC7F930001BE; Thu, 30 Jan 2025 18:15:23 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TSIYzh4U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738260931;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ayjQ16AKVVeKMm/QChUsk+0M85GFICyQUxjzHnGuJts=;\n\tb=TSIYzh4UIqj7I8UxmHpqMKEw6DFpAhJ+zW1/BYIeLRf71f2u6BnAZJJB4cLoR08pE4FFHJ\n\tiIVo3n0ESfXS/2zkIRBXJZ63grlESHLMyR0zJs46/TaiRLG6w6iY/PeoAlmUARu3aKv/Wh\n\tNOVvAFipeLEUVwFNnBBRlMIQ8/CJ2+g=", "X-MC-Unique": "5MI7k_16OH6o9zN76IhlMQ-1", "X-Mimecast-MFC-AGG-ID": "5MI7k_16OH6o9zN76IhlMQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 08/10] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml", "Date": "Thu, 30 Jan 2025 19:14:45 +0100", "Message-ID": "<20250130181449.130492-9-mzamazal@redhat.com>", "In-Reply-To": "<20250130181449.130492-1-mzamazal@redhat.com>", "References": "<20250130181449.130492-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "DiO_CdDy0XD6o7sYix7StDmbaGmTIgZ11aCmLIblU-U_1738260926", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For performance reasons, color correction matrix (CCM) is not applied by\ndefault in software ISP. But let's add a commented out example how to\ndefine it to the default tuning file.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/data/uncalibrated.yaml | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\nindex 3f147112..5508e668 100644\n--- a/src/ipa/simple/data/uncalibrated.yaml\n+++ b/src/ipa/simple/data/uncalibrated.yaml\n@@ -5,6 +5,15 @@ version: 1\n algorithms:\n - BlackLevel:\n - Awb:\n+ # Color correction matrices can be defined here. The CCM algorithm\n+ # has a significant performance impact, and should only be enabled\n+ # if tuned.\n+ # - Ccm:\n+ # ccms:\n+ # - ct: 6500\n+ # ccm: [ 1, 0, 0,\n+ # 0, 1, 0,\n+ # 0, 0, 1]\n - Lut:\n - Agc:\n ...\n", "prefixes": [ "v5", "08/10" ] }