Patch Detail
Show a patch.
GET /api/patches/22661/?format=api
{ "id": 22661, "url": "https://patchwork.libcamera.org/api/patches/22661/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22661/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130115001.1129305-3-pobrn@protonmail.com>", "date": "2025-01-30T11:50:13", "name": "[RFC,v3,02/21] apps: common: event_loop: Disable copy/move", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7ef779e21068dbb982d3a4ff118838a8eb82e94b", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22661/mbox/", "series": [ { "id": 4978, "url": "https://patchwork.libcamera.org/api/series/4978/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4978", "date": "2025-01-30T11:50:08", "name": "apps: lc-compliance: Multi-stream tests", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4978/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22661/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22661/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92F4DBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 11:50:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 490496856A;\n\tThu, 30 Jan 2025 12:50:21 +0100 (CET)", "from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45F076851B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 12:50:19 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"KWtOvRPx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237818; x=1738497018;\n\tbh=QWjz6/M4YbBh8sUNp10+V/Pp31LxoiqvTTEfCQGMAR4=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=KWtOvRPx14paoEq62XHhAyzlZ2jmodxMjwqPTlvfCmSQjlKJiDE1Le2Q9JxO1xmYi\n\tDCvYFNbZ4kREdJ/7AlMizoG814go/0Fnf57zVTZCoejgSbqCJ0jm3m7ciGMZhdMPTj\n\tULZEzUomVcE4VGBrbBqoW/wUDZsGofKbdbzpC5PH5ceVLwA+7kOBDVpuxZ0r4c+ENa\n\tbCtEu5i5MG8oucx2lN0CxvOt24H6aKcwrcMKrKzz3VdgzwvOnYpt2aZOMZlNTSO+31\n\tAq9vNaxwrqtPxc6pHnYawOK9ZX5sneLospFysc/7lWuplw8P5TuKxCQmRbUtUhPbM8\n\t+cXgrHQy0Q90g==", "Date": "Thu, 30 Jan 2025 11:50:13 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[RFC PATCH v3 02/21] apps: common: event_loop: Disable copy/move", "Message-ID": "<20250130115001.1129305-3-pobrn@protonmail.com>", "In-Reply-To": "<20250130115001.1129305-1-pobrn@protonmail.com>", "References": "<20250130115001.1129305-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "1cff335e5849fb761b04346b83305d872fc30d22", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The compiler generated functions are not appropriate, so\ndelete the copy/move constructor/assignment to avoid\npotential issues.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/apps/common/event_loop.h | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/apps/common/event_loop.h b/src/apps/common/event_loop.h\nindex d7d012c76..4e8dd0a46 100644\n--- a/src/apps/common/event_loop.h\n+++ b/src/apps/common/event_loop.h\n@@ -13,6 +13,8 @@\n #include <memory>\n #include <mutex>\n \n+#include <libcamera/base/class.h>\n+\n #include <event2/util.h>\n \n struct event_base;\n@@ -43,8 +45,11 @@ public:\n \t\t\t std::function<void()> &&handler);\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(EventLoop)\n+\n \tstruct Event {\n \t\tEvent(std::function<void()> &&callback);\n+\t\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Event)\n \t\t~Event();\n \n \t\tstatic void dispatch(int fd, short events, void *arg);\n", "prefixes": [ "RFC", "v3", "02/21" ] }