Patch Detail
Show a patch.
GET /api/patches/2266/?format=api
{ "id": 2266, "url": "https://patchwork.libcamera.org/api/patches/2266/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2266/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191028022525.796995-6-niklas.soderlund@ragnatech.se>", "date": "2019-10-28T02:25:18", "name": "[libcamera-devel,RFC,05/12] libcamera: buffer: Remove request tracking", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e132cb2bdfaca29d69c3ec88817fa3e6a9f5eba3", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2266/mbox/", "series": [ { "id": 561, "url": "https://patchwork.libcamera.org/api/series/561/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=561", "date": "2019-10-28T02:25:13", "name": "libcamera: Rework buffer API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/561/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2266/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2266/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E5A46150A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2019 03:25:53 +0100 (CET)", "from localhost.localdomain (unknown [93.2.121.143])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 412752f6-f92a-11e9-903a-005056917f90;\n\tMon, 28 Oct 2019 03:25:49 +0100 (CET)" ], "X-Halon-ID": "412752f6-f92a-11e9-903a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Oct 2019 03:25:18 +0100", "Message-Id": "<20191028022525.796995-6-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191028022525.796995-1-niklas.soderlund@ragnatech.se>", "References": "<20191028022525.796995-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 05/12] libcamera: buffer: Remove request\n\ttracking", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 28 Oct 2019 02:25:53 -0000" }, "content": "It's no longer needed to track which request the application provided\nbuffer belongs to, drop the helpers for this.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/buffer.h | 4 ----\n src/libcamera/buffer.cpp | 3 +--\n src/libcamera/request.cpp | 3 ---\n 3 files changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex c349b995e1eb35ee..54c757ef7db8b5f6 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -83,7 +83,6 @@ public:\n \tunsigned int sequence() const { return sequence_; }\n \n \tStatus status() const { return status_; }\n-\tRequest *request() const { return request_; }\n \tStream *stream() const { return stream_; }\n \n private:\n@@ -94,8 +93,6 @@ private:\n \n \tvoid cancel();\n \n-\tvoid setRequest(Request *request) { request_ = request; }\n-\n \tunsigned int index_;\n \tstd::array<int, 3> dmabuf_;\n \tBufferMemory *mem_;\n@@ -105,7 +102,6 @@ private:\n \tunsigned int sequence_;\n \n \tStatus status_;\n-\tRequest *request_;\n \tStream *stream_;\n };\n \ndiff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 4407201bd81c368d..10b16a862393b536 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -270,8 +270,7 @@ void BufferPool::destroyBuffers()\n */\n Buffer::Buffer(unsigned int index, const Buffer *metadata)\n \t: index_(index), dmabuf_({ -1, -1, -1 }),\n-\t status_(Buffer::BufferSuccess), request_(nullptr),\n-\t stream_(nullptr)\n+\t status_(Buffer::BufferSuccess), stream_(nullptr)\n {\n \tif (metadata) {\n \t\tbytesused_ = metadata->bytesused_;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex c14ed1a4d3ce55d0..a9468ed4b0512a7f 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -220,7 +220,6 @@ int Request::prepare()\n \n \tfor (auto const &pair : bufferMap_) {\n \t\tBuffer *buffer = pair.second;\n-\t\tbuffer->setRequest(this);\n \t\tpending_.insert(buffer);\n \t}\n \n@@ -258,8 +257,6 @@ bool Request::completeBuffer(Buffer *buffer)\n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n \n-\tbuffer->setRequest(nullptr);\n-\n \tif (buffer->status() == Buffer::BufferCancelled)\n \t\tcancelled_ = true;\n \n", "prefixes": [ "libcamera-devel", "RFC", "05/12" ] }