Patch Detail
Show a patch.
GET /api/patches/22659/?format=api
{ "id": 22659, "url": "https://patchwork.libcamera.org/api/patches/22659/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22659/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130074712.959046-1-pobrn@protonmail.com>", "date": "2025-01-30T07:47:15", "name": "[v1] Documentation: guides: application-developer: Fix variable shadowing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "14d795382b8e7dbf189fdf339ff6f6e61c279a0d", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22659/mbox/", "series": [ { "id": 4977, "url": "https://patchwork.libcamera.org/api/series/4977/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4977", "date": "2025-01-30T07:47:15", "name": "[v1] Documentation: guides: application-developer: Fix variable shadowing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4977/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22659/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22659/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F91FBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 07:47:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC80068562;\n\tThu, 30 Jan 2025 08:47:22 +0100 (CET)", "from mail-10628.protonmail.ch (mail-10628.protonmail.ch\n\t[79.135.106.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 302806034B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 08:47:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"hOqpeqU7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738223240; x=1738482440;\n\tbh=zpP2GHJCFJ9x/J3BVlu4zLNIj1r+2vqu5/QNF89NN5E=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=hOqpeqU7lZVLiImRu8JcYtXBwshEu0BzdL53GlA/AnQbjTUF++s/EoAFXC2K3Sea+\n\tL31z/ZqnFLtoaGQYlz49D/oOtJfWSQj93+eynt/HNqvBEk4tZT3OtbfiHRDkzeF6fi\n\tSE5sq0Q65m+VZI+9+9x/nowikI3jwjS8Yrh1KWDYRJN7t6iRxhHjDS1Gua3O0BEggo\n\tQtU0uXP2MLGk/XXT14KrrDoJ8wl9Wl8E7FRGtPAEpSfReLumHsZ3VijTTgwdhrOP+S\n\tPapgFeGuWXabH5OcRyEhSCALBvW8OffEbzG6FFMu14VdTH6VRNAPWYGOfqpSFaqFvV\n\tzw8UbLgaSc1kw==", "Date": "Thu, 30 Jan 2025 07:47:15 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing", "Message-ID": "<20250130074712.959046-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "0050fef5813c7120335ffbb59494ea6cebaeb50d", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The mentioned commit mistakenly introduced a new variable for storing\nthe camera instead of just assigining to the global variable defined\nearlier in the tutorial. Fix that by making it an assignment.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=252\nFixes: e77a2751100e38 (\"treewide: Query list of cameras just once\")\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n Documentation/guides/application-developer.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex 67f5bd7e7..297586a1c 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -128,7 +128,7 @@ available.\n \n std::string cameraId = cameras[0]->id();\n \n- auto camera = cm->get(cameraId);\n+ camera = cm->get(cameraId);\n /*\n * Note that `camera` may not compare equal to `cameras[0]`.\n * In fact, it might simply be a `nullptr`, as the particular\n", "prefixes": [ "v1" ] }