Patch Detail
Show a patch.
GET /api/patches/22607/?format=api
{ "id": 22607, "url": "https://patchwork.libcamera.org/api/patches/22607/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22607/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250121185554.301901-4-pobrn@protonmail.com>", "date": "2025-01-21T18:56:11", "name": "[RFC,v1,6/7] libcamera: base: log: Pass dynamic prefix through", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "75e58374a8015938a5a1566215669adbf38e8257", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22607/mbox/", "series": [ { "id": 4960, "url": "https://patchwork.libcamera.org/api/series/4960/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4960", "date": "2025-01-21T18:50:47", "name": "libcamera: base: log: Misc. changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4960/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22607/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22607/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DFB7BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Jan 2025 18:56:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EDA56855C;\n\tTue, 21 Jan 2025 19:56:17 +0100 (CET)", "from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D3D468503\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Jan 2025 19:56:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"kjsVaL0v\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1737485775; x=1737744975;\n\tbh=cBhOGid0r8VciX/qWugH9YEsNhr4QLNKHtT5Z78Y72c=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=kjsVaL0vvMbGosX9EdQPsmozdEVHXAwJ9I2f+taJqY23s40yj9PTAXU5fq5Kee6LB\n\tbB/8kKEYIcS9EStWg4WPQHVDLIQZUOb54G1Xm5MAHeSGW1Z4v70slCObrzMXX5Iqfz\n\tKzDkG8Op9+/i8KtlZ1VfPiQCwTwvh+W/mnodZxOWg91VQLwDVgvKp58k+epHRzK19L\n\tEhv12h4YW4bzSEHWqBPo9jqu11X4C/VylL0g1nritZuHN45lKPqXNKe0dVtyomYYuM\n\tkZ5HGIC1r8wSc/xcKFX+kkYTYHznpuAC1LEeAJTSk0A4rFOIUmFitNrrP6BvfG6ls0\n\tzyYec02InricA==", "Date": "Tue, 21 Jan 2025 18:56:11 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[RFC PATCH v1 6/7] libcamera: base: log: Pass dynamic prefix through", "Message-ID": "<20250121185554.301901-4-pobrn@protonmail.com>", "In-Reply-To": "<20250121185554.301901-1-pobrn@protonmail.com>", "References": "<20250121185554.301901-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "b87d09b4fbb4ab77f22944f33f63bc361d8a487e", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use move construction to essentially pass through the string\nreturned by `Loggable::logPrefix()` to avoid an unnecessary copy.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n include/libcamera/base/log.h | 2 +-\n src/libcamera/base/log.cpp | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex 9c7775660..ef161bece 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -64,7 +64,7 @@ class LogMessage\n public:\n \tLogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix = std::string());\n+\t\t std::string prefix = {});\n \n \tLogMessage(LogMessage &&);\n \t~LogMessage();\ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 78db4990c..6430650ec 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -873,9 +873,9 @@ const LogCategory &LogCategory::defaultCategory()\n */\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix)\n+\t\t std::string prefix)\n \t: category_(category), severity_(severity),\n-\t timestamp_(utils::clock::now()), prefix_(prefix)\n+\t timestamp_(utils::clock::now()), prefix_(std::move(prefix))\n {\n \tstd::ostringstream ossFileInfo;\n \tossFileInfo << utils::basename(fileName) << \":\" << line;\n", "prefixes": [ "RFC", "v1", "6/7" ] }