Patch Detail
Show a patch.
GET /api/patches/22602/?format=api
{ "id": 22602, "url": "https://patchwork.libcamera.org/api/patches/22602/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22602/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250121185044.300816-2-pobrn@protonmail.com>", "date": "2025-01-21T18:50:52", "name": "[RFC,v1,1/7] libcamera: base: log: Move all fields of `LogMessage`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c0b675b83bbd0e35c55d3bb5894fa5d1bccc94c5", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22602/mbox/", "series": [ { "id": 4960, "url": "https://patchwork.libcamera.org/api/series/4960/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4960", "date": "2025-01-21T18:50:47", "name": "libcamera: base: log: Misc. changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4960/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22602/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22602/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0999DC330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Jan 2025 18:50:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A87406855B;\n\tTue, 21 Jan 2025 19:50:58 +0100 (CET)", "from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5571C60380\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Jan 2025 19:50:57 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"BNf3LcRm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1737485456; x=1737744656;\n\tbh=5i8jlI0r5scu2yXPeGcWMDWPcNk23fMJN2hE4FT/2nc=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=BNf3LcRmo+DgmkY4HvADX83nvZUqSTNY41F6jOiThxgNXSxv383yAqkdGFzoBU4VP\n\tjfUQqmqnSt+8yzeX1rAlEYgpGzxXlEOkFHq9ZMi2b4k4AbB1BRq+1Hj4/QGR/cEO6x\n\tD7pmf/8inSLMASfEjFAoo4xdarWmi2oye7/j9GixKLnU5ltjTQOKd+YMuaU+SLpEpz\n\tV7E45junt+W2CH3GW9FESTyke0iZvVt/XEy1mtcrRWbYFygPD7Ku3Yf+5qrI98ebzS\n\t+UPYFBcspvwsfZOyjEY1gPo+U7Wr6erFt0esZrw4KqTA2DEjQgZFdg8f3JzA1vPIHb\n\t10G5bwpb3itwQ==", "Date": "Tue, 21 Jan 2025 18:50:52 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[RFC PATCH v1 1/7] libcamera: base: log: Move all fields of\n\t`LogMessage`", "Message-ID": "<20250121185044.300816-2-pobrn@protonmail.com>", "In-Reply-To": "<20250121185044.300816-1-pobrn@protonmail.com>", "References": "<20250121185044.300816-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "4b6c4e5ec3332e831eb0b7276d6d7b773a1fbcb7", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move all fields of `LogMessage` in the move constructor.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/libcamera/base/log.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 3a656b8f0..61a43d525 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -17,6 +17,7 @@\n #include <syslog.h>\n #include <time.h>\n #include <unordered_set>\n+#include <utility>\n \n #include <libcamera/logging.h>\n \n@@ -894,9 +895,10 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n */\n LogMessage::LogMessage(LogMessage &&other)\n \t: msgStream_(std::move(other.msgStream_)), category_(other.category_),\n-\t severity_(other.severity_)\n+\t severity_(std::exchange(other.severity_, LogInvalid)),\n+\t timestamp_(other.timestamp_), fileInfo_(std::move(other.fileInfo_)),\n+\t prefix_(std::move(other.prefix_))\n {\n-\tother.severity_ = LogInvalid;\n }\n \n void LogMessage::init(const char *fileName, unsigned int line)\n", "prefixes": [ "RFC", "v1", "1/7" ] }