Patch Detail
Show a patch.
GET /api/patches/226/?format=api
{ "id": 226, "url": "https://patchwork.libcamera.org/api/patches/226/?format=api", "web_url": "https://patchwork.libcamera.org/patch/226/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190114223248.8643-1-kieran.bingham@ideasonboard.com>", "date": "2019-01-14T22:32:48", "name": "[libcamera-devel,v2] meson: Utilise default compiler options", "commit_ref": "a5e86d4396ae7221e431a748559e56a8d024e43e", "pull_url": null, "state": "accepted", "archived": false, "hash": "36990fa24d0b3d1b2b09b74543e8e4ebd2b0fa6d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/226/mbox/", "series": [ { "id": 79, "url": "https://patchwork.libcamera.org/api/series/79/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=79", "date": "2019-01-14T22:32:48", "name": "[libcamera-devel,v2] meson: Utilise default compiler options", "version": 2, "mbox": "https://patchwork.libcamera.org/series/79/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/226/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/226/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87D3C60B21\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jan 2019 23:32:53 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5095510;\n\tMon, 14 Jan 2019 23:32:52 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547505173;\n\tbh=fHiPWj4Ti5pQuK0JCgnn/hxn4tlDU2uIzUQxOfAX3H8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SXFszd5RHEnxhtzZ9fDzEkhkZ9JjMCksJJicpR7F97cNzZ5HMJ5j8XiBDZoM/ib/g\n\tesIQPlXUWJ4rVu8n2Vqr/63nu8n3ACzHWE/sqq/cmz4ae1PnauemfO+YNv8Q5PW6eu\n\tKGOT12xt8Yg1wGMHMMhiGNlVW3HbpSS9eGcxNPC4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 14 Jan 2019 22:32:48 +0000", "Message-Id": "<20190114223248.8643-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190114100346.17925-1-kieran.bingham@ideasonboard.com>", "References": "<20190114100346.17925-1-kieran.bingham@ideasonboard.com>", "Subject": "[libcamera-devel] [PATCH v2] meson: Utilise default compiler options", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 14 Jan 2019 22:32:53 -0000" }, "content": "Remove our custom declarations for cpp_std=c++11, -Wall, -Wextra and\n-Werror, instead prefering to use the built-in default_option parameters\nfrom meson.\n\nOur custom compiler flags (such as -Wno-unused-parameter) are\nmaintained.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv2:\n - Remove duplicated -Wall, -Wextra flags which are provided at\n warning_level=2\n\n meson.build | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 0ab0da981083..4465a3851a30 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1,6 +1,11 @@\n project('libcamera', 'c', 'cpp',\n meson_version: '>= 0.40',\n version : '0.1',\n+ default_options: [\n+ 'werror=true',\n+ 'warning_level=2',\n+ 'cpp_std=c++11',\n+ ],\n license : 'LGPL 2.1+')\n \n # TODO: Extract this from project.version.\n@@ -9,15 +14,11 @@ project('libcamera', 'c', 'cpp',\n api_version = '0.1'\n \n common_arguments = [\n- '-Wall',\n- '-Wextra',\n- '-Werror',\n '-Wno-unused-parameter',\n ]\n \n c_arguments = common_arguments\n cpp_arguments = common_arguments\n-cpp_arguments += '-std=c++11'\n \n add_project_arguments(c_arguments, language: 'c')\n add_project_arguments(cpp_arguments, language: 'cpp')\n", "prefixes": [ "libcamera-devel", "v2" ] }