Patch Detail
Show a patch.
GET /api/patches/22599/?format=api
{ "id": 22599, "url": "https://patchwork.libcamera.org/api/patches/22599/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22599/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250120204515.24096-13-laurent.pinchart@ideasonboard.com>", "date": "2025-01-20T20:45:03", "name": "[v9,12/12] ipa: raspberry: Report new AeEnable control as available", "commit_ref": "fdc01dc3e0969423d65ee87f118164ec74373e5d", "pull_url": null, "state": "accepted", "archived": false, "hash": "625740b710251d1bb4ead4412f9cc78903a91284", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22599/mbox/", "series": [ { "id": 4958, "url": "https://patchwork.libcamera.org/api/series/4958/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4958", "date": "2025-01-20T20:44:51", "name": "AEGC controls", "version": 9, "mbox": "https://patchwork.libcamera.org/series/4958/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22599/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22599/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71797C3316\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jan 2025 20:45:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6F4D6855E;\n\tMon, 20 Jan 2025 21:45:50 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 179546855E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jan 2025 21:45:39 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5694322A;\n\tMon, 20 Jan 2025 21:44:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vtginwzf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737405877;\n\tbh=V2AwM77ZACctVud/nFgqq9P/EKmhF5hJ/kf+VZjFq1U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VtginwzfeWz/H2l667N9bDp2YdyoTwYpRpY0C2fqRSPO2InS7Hy4JDKNw6HxU9t8z\n\tDw/0l2poxsFcNgJEuhry3Lel//ohOywzV3eGfWO0KKYQcrH3bLX5f4nDJNquYhdf5L\n\tCmiAhsDALfi4qLfvl5VbIrLXrrvZOxHaA5S6RBXs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v9 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable", "Date": "Mon, 20 Jan 2025 22:45:03 +0200", "Message-ID": "<20250120204515.24096-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>", "References": "<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Paul Elder <paul.elder@ideasonboard.com>\n\nEven though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrpi IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 5210a1f38efb..bd3c22000df5 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n \n /* List of controls handled by the Raspberry Pi IPA */\n const ControlInfoMap::Map ipaControls{\n+\t/* \\todo Move this to the Camera class */\n+\t{ &controls::AeEnable, ControlInfo(false, true, true) },\n \t{ &controls::ExposureTimeMode,\n \t ControlInfo(static_cast<int32_t>(controls::ExposureTimeModeAuto),\n \t\t static_cast<int32_t>(controls::ExposureTimeModeManual),\n", "prefixes": [ "v9", "12/12" ] }