Patch Detail
Show a patch.
GET /api/patches/22578/?format=api
{ "id": 22578, "url": "https://patchwork.libcamera.org/api/patches/22578/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22578/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250114211935.715028-1-kieran.bingham@ideasonboard.com>", "date": "2025-01-14T21:19:35", "name": "libcamera: meson: Fix libyuv detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3e92ce0efd5b5df1a42cb423da1b3cfb50c026dc", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22578/mbox/", "series": [ { "id": 4952, "url": "https://patchwork.libcamera.org/api/series/4952/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4952", "date": "2025-01-14T21:19:35", "name": "libcamera: meson: Fix libyuv detection", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4952/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22578/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22578/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A75CC3304\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jan 2025 21:19:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B4F968521;\n\tTue, 14 Jan 2025 22:19:48 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30870607D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2025 22:19:47 +0100 (CET)", "from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DC13842;\n\tTue, 14 Jan 2025 22:18:49 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Rl+DXW8V\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736889529;\n\tbh=G4wVwFJxCLvJzg9zUtk/FmuoOG2IyeRuBp7rm0/PNvg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Rl+DXW8V/5gX7tA98tBjX5eu/XHIw5WH7uRcb9C76xc3qCIxx+Jyl+aZK57Kgi1pR\n\t4FSmXHvYN80TRZycuemTKrACr9PnMhTGPFGPWRw/SxcVtKHEz1gDviBUvIjIafAT85\n\tGTAHYs2owtIPlTj6cN4rf1MWiuZ/Ruljc6yxVFuc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "=?utf-8?q?Dylan_A=C3=AFssi?= <daissi@debian.org>,\n\t=?utf-8?q?Dylan_A=C3=AFssi?= <dylan.aissi@collabora.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] libcamera: meson: Fix libyuv detection", "Date": "Tue, 14 Jan 2025 21:19:35 +0000", "Message-ID": "<20250114211935.715028-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Dylan Aïssi <daissi@debian.org>\n\nWe already fall back to a subproject to support the libyuv package when\nit can not be discovered through the usual dependency() mechanism.\n\nUnfortunately libyuv may be packaged without any corresponding\npkg-config support as can be seen at [0], so further extend the\ndependency search by using an explicit cc.find_library() call.\n\n[0] https://packages.debian.org/bookworm/amd64/libyuv-dev/filelist\n\nSigned-off-by: Dylan Aïssi <dylan.aissi@collabora.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/meson.build | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/meson.build b/src/meson.build\nindex 76198e9535db..0a9cdff8e7dc 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -27,10 +27,15 @@ else\n ipa_sign_module = false\n endif\n \n-# libyuv, used by the Android adaptation layer and the virtual pipeline handler.\n-# Fallback to a subproject if libyuv isn't found, as it's typically not provided\n-# by distributions.\n+# libyuv, used by the Android adaptation layer and the virtual pipeline\n+# handler. Fallback to a subproject if libyuv isn't found, as it's typically\n+# not provided by distributions. Where libyuv is provided by a distribution, it\n+# may not always supply a pkg-config implementation, requiring cc.find_library()\n+# to search for it.\n libyuv_dep = dependency('libyuv', required : false)\n+if not libyuv_dep.found()\n+ libyuv_dep = cc.find_library('yuv', required: false)\n+endif\n \n if (pipelines.contains('virtual') or get_option('android').allowed()) and \\\n not libyuv_dep.found()\n", "prefixes": [] }