Patch Detail
Show a patch.
GET /api/patches/22569/?format=api
{ "id": 22569, "url": "https://patchwork.libcamera.org/api/patches/22569/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22569/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250114182143.1773762-9-pobrn@protonmail.com>", "date": "2025-01-14T18:22:28", "name": "[RFC,v2,08/16] apps: lc-compliance: Remove redundant getter call", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e74b960ea8c6e8bd7d57d9ace6fd4c46cf247ba5", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22569/mbox/", "series": [ { "id": 4951, "url": "https://patchwork.libcamera.org/api/series/4951/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4951", "date": "2025-01-14T18:21:46", "name": "apps: lc-compliance: Multi-stream tests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4951/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22569/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22569/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 097B1C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jan 2025 18:22:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF4BB6854C;\n\tTue, 14 Jan 2025 19:22:32 +0100 (CET)", "from mail-10629.protonmail.ch (mail-10629.protonmail.ch\n\t[79.135.106.29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B36D5684E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2025 19:22:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"o7J4qkTh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736878951; x=1737138151;\n\tbh=wkrIB4YgmYKmQEgNV1q7PTX5QcDbokZN9TquUHAcD+I=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=o7J4qkThVbmGwAdTOExh27PS+mUmb7qrQM7xP99ncN5UHSZCufW8/wrWhT6iEkiD5\n\tAP2w526Xc2YLBt6VsAY7NzEdw063HPzxUupi9PaDq/0qOMMuRfcyjdsPO+XALyONgx\n\t17QaNkQFN2JUCS3umEjulkoVMHDF3+AUs6G4/bFyzwO19eMt/kNQMpEIB+jL2LE9gU\n\tpP/0u2upZeVdO9FGwGFdIO4D165RvpsHeK0UoHvgo4xIR+6FSFT9m4LsoOiJXVFIzH\n\ttmKxQLTRqwy8zcsySOpSX+HpKCNb7bURrVB2vvlUDfAh2ZaUoMHD/8HfyykUCzNZ87\n\txGHeKiy+NeuRQ==", "Date": "Tue, 14 Jan 2025 18:22:28 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v2 08/16] apps: lc-compliance: Remove redundant getter\n\tcall", "Message-ID": "<20250114182143.1773762-9-pobrn@protonmail.com>", "In-Reply-To": "<20250114182143.1773762-1-pobrn@protonmail.com>", "References": "<20250114182143.1773762-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "6e36770f0607cdcefc1c740cdd70c334b17daec6", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Smart pointers overload `operator->()`, no reason to use `get()`.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/lc-compliance/main.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\nindex 98f2573d0..cdd0bd515 100644\n--- a/src/apps/lc-compliance/main.cpp\n+++ b/src/apps/lc-compliance/main.cpp\n@@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener\n static void listCameras(CameraManager *cm)\n {\n \tfor (const std::shared_ptr<Camera> &cam : cm->cameras())\n-\t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n+\t\tstd::cout << \"- \" << cam->id() << std::endl;\n }\n \n static int initCamera(CameraManager *cm, OptionsParser::Options options)\n", "prefixes": [ "RFC", "v2", "08/16" ] }