Patch Detail
Show a patch.
GET /api/patches/22566/?format=api
{ "id": 22566, "url": "https://patchwork.libcamera.org/api/patches/22566/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22566/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250114182143.1773762-6-pobrn@protonmail.com>", "date": "2025-01-14T18:22:10", "name": "[RFC,v2,05/16] apps: lc-compliance: Initialize `CameraManager` pointer in `Environment`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d249066b0c87b722871e3bcc3a3b0dcf89afc54b", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22566/mbox/", "series": [ { "id": 4951, "url": "https://patchwork.libcamera.org/api/series/4951/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4951", "date": "2025-01-14T18:21:46", "name": "apps: lc-compliance: Multi-stream tests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4951/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22566/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22566/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4764BC3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jan 2025 18:22:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0391E6854A;\n\tTue, 14 Jan 2025 19:22:19 +0100 (CET)", "from mail-10630.protonmail.ch (mail-10630.protonmail.ch\n\t[79.135.106.30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA1768543\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2025 19:22:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"rC0OLE2N\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736878936; x=1737138136;\n\tbh=4KsJUL43WBdIJl+z/IPEcU7jqnKztejvM2uOv6LYFvA=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=rC0OLE2NlJyn2+EMUl2GadB2ZtXuVU2UcS+pXFmlW5CZ2zPjtddEB1bFgBXCLGKlo\n\tDhA9KCattS5xw0xZZP3Ysa+LBUt2HmCGK+69nAiS/Uk0VgekeN/IP4dkEGrABERE0d\n\t6v1U/t3fWPqbWwnoj1jO1VjUKtmurqGrKRDvzr85ydN6AV8V2Hi3IuaVTZRVwCBNGw\n\tGkRIGuq3GK1ewZ0NsJT/V1uWf7XGS7PnlkZ5TDOuJ66ckefdx5cbpS6woiWjJcd8pv\n\tV0qRfLvR+HtcmQ0TNwZ1wbBmykr8X5LuUdIP8fhN8U9/CYST1dHpJ1R5r41/11jx2R\n\tYfzkCy6LIl/ow==", "Date": "Tue, 14 Jan 2025 18:22:10 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v2 05/16] apps: lc-compliance: Initialize `CameraManager`\n\tpointer in `Environment`", "Message-ID": "<20250114182143.1773762-6-pobrn@protonmail.com>", "In-Reply-To": "<20250114182143.1773762-1-pobrn@protonmail.com>", "References": "<20250114182143.1773762-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "42a4e038021d5e82c75ed42c7fc4578d6a698b6f", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Do not leave it unitialized.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/lc-compliance/environment.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h\nindex 543e5372f..834c722ef 100644\n--- a/src/apps/lc-compliance/environment.h\n+++ b/src/apps/lc-compliance/environment.h\n@@ -23,5 +23,5 @@ private:\n \tEnvironment() = default;\n \n \tstd::string cameraId_;\n-\tlibcamera::CameraManager *cm_;\n+\tlibcamera::CameraManager *cm_ = nullptr;\n };\n", "prefixes": [ "RFC", "v2", "05/16" ] }