Patch Detail
Show a patch.
GET /api/patches/22559/?format=api
{ "id": 22559, "url": "https://patchwork.libcamera.org/api/patches/22559/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22559/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250113215946.1033762-13-paul.elder@ideasonboard.com>", "date": "2025-01-13T21:59:46", "name": "[v8,12/12] ipa: raspberry: Report new AeEnable control as available", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "625740b710251d1bb4ead4412f9cc78903a91284", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22559/mbox/", "series": [ { "id": 4949, "url": "https://patchwork.libcamera.org/api/series/4949/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4949", "date": "2025-01-13T21:59:34", "name": "AEGC controls", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4949/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22559/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22559/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23B38BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 22:02:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90ED768555;\n\tMon, 13 Jan 2025 23:02:27 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45C0768557\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 23:02:25 +0100 (CET)", "from pyrite.hamster-moth.ts.net (unknown [173.16.167.215])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FC684388;\n\tMon, 13 Jan 2025 23:01:27 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T8wgs2U6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736805688;\n\tbh=51hnUcpAKWE15oX752PYg+bqUwWeVn4sj40cgvK8qpk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T8wgs2U6Jbmg9nktB2R1E5j5uw69GvGIhHMdMR6Kpi59LNms3b53QYwteqhaglxIo\n\tbpbq1LWiLljFQ2UJriWb00oCryd7WxlEXzh4DrZE0IFprv+b8R7J+a7yMEopzBgZKT\n\tJ86xTLEHHbOsXfkB4ca8eEXauCLae0EF23llTBSk=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tlaurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com,\n\tdavid.plowman@raspberrypi.com, naush@raspberrypi.com", "Subject": "[PATCH v8 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable", "Date": "Mon, 13 Jan 2025 15:59:46 -0600", "Message-Id": "<20250113215946.1033762-13-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "References": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Even though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrpi IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\nChanges in v8:\n- add \"true\" as default value\n\nNo change in v7\n\nNew in v6\n---\n src/ipa/rpi/common/ipa_base.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 0fb58c1d0..a5c46e6ec 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n \n /* List of controls handled by the Raspberry Pi IPA */\n const ControlInfoMap::Map ipaControls{\n+\t/* \\todo Move this to the Camera class */\n+\t{ &controls::AeEnable, ControlInfo(false, true, true) },\n \t{ &controls::ExposureTimeMode,\n \t ControlInfo(static_cast<int32_t>(controls::ExposureTimeModeAuto),\n \t\t static_cast<int32_t>(controls::ExposureTimeModeManual),\n", "prefixes": [ "v8", "12/12" ] }