Patch Detail
Show a patch.
GET /api/patches/22555/?format=api
{ "id": 22555, "url": "https://patchwork.libcamera.org/api/patches/22555/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22555/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250113215946.1033762-9-paul.elder@ideasonboard.com>", "date": "2025-01-13T21:59:42", "name": "[v8,08/12] controls: Remove AeLocked", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d0e40e771b202bc9ba26ed1e700324b15db43489", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22555/mbox/", "series": [ { "id": 4949, "url": "https://patchwork.libcamera.org/api/series/4949/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4949", "date": "2025-01-13T21:59:34", "name": "AEGC controls", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4949/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22555/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22555/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A886C3303\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 22:02:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 902AF68555;\n\tMon, 13 Jan 2025 23:02:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 117376854A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 23:02:20 +0100 (CET)", "from pyrite.hamster-moth.ts.net (unknown [173.16.167.215])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7FC24372;\n\tMon, 13 Jan 2025 23:01:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dy2uuWY2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736805683;\n\tbh=o9i3E9E4nkzI8RBiFEZbmBce1BGp1ANji2QufHlPK40=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dy2uuWY2h8rDIiInZByMDWI7kwdAHNDfHeEoJhsWRSax+MM+VxPmtROGrK3clX7Cs\n\tet2XbMduUeJA2t5uefk/rEshPmuTTTcDvzZZxsJS263sJb8Xq/z6Nz9qrSUkz83SMf\n\tW4s1SRna2Cmc/9I1vdIQuAczSRAGIEF3G4JlAGwY=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo@jmondi.org>, laurent.pinchart@ideasonboard.com,\n\tstefan.klug@ideasonboard.com, Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v8 08/12] controls: Remove AeLocked", "Date": "Mon, 13 Jan 2025 15:59:42 -0600", "Message-Id": "<20250113215946.1033762-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "References": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nNow that the codebase has been ported to use the new AEGC controls\nremove the definition of AeLocked. AeEnable is not be removed as it will\nbe redefined.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\nNo change in v8\n\nNo change in v7\n\nChanges in v6:\n- remove only AeLocked, as AeEnable will be redefined instead of removed\n - (used to be \"controls: Remove AeEnable and AeLocked\")\n\nNo change in v5\n\nNo change in v4\n\nNo change in v3\n---\n src/libcamera/control_ids_core.yaml | 12 ------------\n 1 file changed, 12 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 553095481..d88c1852e 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -16,18 +16,6 @@ controls:\n \n \\sa ExposureTime AnalogueGain\n \n- - AeLocked:\n- type: bool\n- direction: out\n- description: |\n- Report the lock status of a running AE algorithm.\n-\n- If the AE algorithm is locked the value shall be set to true, if it's\n- converging it shall be set to false. If the AE algorithm is not\n- running the control shall not be present in the metadata control list.\n-\n- \\sa AeEnable\n-\n - AeState:\n type: int32_t\n direction: out\n", "prefixes": [ "v8", "08/12" ] }