Patch Detail
Show a patch.
GET /api/patches/22531/?format=api
{ "id": 22531, "url": "https://patchwork.libcamera.org/api/patches/22531/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22531/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250113133405.12167-5-mzamazal@redhat.com>", "date": "2025-01-13T13:34:03", "name": "[v3,4/6] ipa: simple: Report black levels in metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "78bb67b4b1c87c63be2cf99bf5cb1205f622adbf", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22531/mbox/", "series": [ { "id": 4945, "url": "https://patchwork.libcamera.org/api/series/4945/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4945", "date": "2025-01-13T13:33:59", "name": "ipa: simple: Introduce metadata reporting", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4945/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22531/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22531/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB476C3302\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 13:34:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAFAD6854B;\n\tMon, 13 Jan 2025 14:34:33 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16A0768516\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 14:34:30 +0100 (CET)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-456-DSS2kCQlMriJQFVgGvfl9Q-1;\n\tMon, 13 Jan 2025 08:34:28 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E2EB2195418F; Mon, 13 Jan 2025 13:34:26 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.6])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 100441955BE3; Mon, 13 Jan 2025 13:34:24 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"MiT/YLhR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1736775269;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=YvSIAvoAeGxxZCw2gRqL5cVuLh8XblZjK2BCGdgI8Zc=;\n\tb=MiT/YLhR+wWzjuZl/NlxMpEIt4I8q15KYZ4+XgLVWnHodSjO6iB5GAtgcQ2tA9elOr5JO6\n\tx3dkSxlKh9IiyW8Fgtli+/WLdjJg1ZE7HZEp++fSisB5ZdFmGrZyDO1GCFmN5btInycmjw\n\teVCelYwldwHgDCc06THjFiOQ1S60750=", "X-MC-Unique": "DSS2kCQlMriJQFVgGvfl9Q-1", "X-Mimecast-MFC-AGG-ID": "DSS2kCQlMriJQFVgGvfl9Q", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <pobrn@protonmail.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v3 4/6] ipa: simple: Report black levels in metadata", "Date": "Mon, 13 Jan 2025 14:34:03 +0100", "Message-ID": "<20250113133405.12167-5-mzamazal@redhat.com>", "In-Reply-To": "<20250113133405.12167-1-mzamazal@redhat.com>", "References": "<20250113133405.12167-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Qxn-geSiruLMii3UEKQSFbq7PYmLkvQPa5tupQGUY90_1736775267", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nProvide the determined black level values in the metadata\nto add to the completed requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/blc.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 1d7d370b..d5759f92 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -11,6 +11,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include \"control_ids.h\"\n+\n namespace libcamera {\n \n namespace ipa::soft::algorithms {\n@@ -49,8 +51,13 @@ void BlackLevel::process(IPAContext &context,\n \t\t\t [[maybe_unused]] const uint32_t frame,\n \t\t\t IPAFrameContext &frameContext,\n \t\t\t const SwIspStats *stats,\n-\t\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t\t ControlList &metadata)\n {\n+\t/* Assign each of the R G G B channels as the same black level. */\n+\tconst int32_t blackLevel = context.activeState.blc.level * 256;\n+\tconst int32_t blackLevels[] = { blackLevel, blackLevel, blackLevel, blackLevel };\n+\tmetadata.set(controls::SensorBlackLevels, blackLevels);\n+\n \tif (context.configuration.black.level.has_value())\n \t\treturn;\n \n", "prefixes": [ "v3", "4/6" ] }