Patch Detail
Show a patch.
GET /api/patches/22470/?format=api
{ "id": 22470, "url": "https://patchwork.libcamera.org/api/patches/22470/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22470/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250108111030.3257931-4-naush@raspberrypi.com>", "date": "2025-01-08T11:09:35", "name": "[v3,3/4] ipa: rpi: Add a HW property to determine if the data buffer is strided", "commit_ref": "cd3dfa1f03ee0113d053ac09f96c607ea341a4c4", "pull_url": null, "state": "accepted", "archived": false, "hash": "08f12b6493b14c9a3abb07784cc7ff08d7434d92", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22470/mbox/", "series": [ { "id": 4934, "url": "https://patchwork.libcamera.org/api/series/4934/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4934", "date": "2025-01-08T11:09:32", "name": "Raspberry Pi: Various changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4934/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22470/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22470/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85BAABD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jan 2025 11:10:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F00568516;\n\tWed, 8 Jan 2025 12:10:41 +0100 (CET)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85D01684E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jan 2025 12:10:37 +0100 (CET)", "by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-4361e82e3c3so25989175e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 Jan 2025 03:10:37 -0800 (PST)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-436e2ddefcbsm17141325e9.22.2025.01.08.03.10.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Jan 2025 03:10:36 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SJ4kK9k1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736334637; x=1736939437;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=;\n\tb=SJ4kK9k1R2xp0iAoTzSFQvWvtBSbDHrAfVbQmk8ukYxOGrl22wihYdK2NEA0/SaLU3\n\tUO5DoCJEQUUny+oaxzfhd5IpyCEpsao1cXNZ4TJRF6iaIl/UaduJ3cWU2efxl+Qp/dFK\n\tWSuP4PtHu7X2hf1b6+8Yp43k/Nqo6tjQyfsUTAaYcrl/61gqoornGjCgh7u3VRCmMjqs\n\tIvDRdTZP57IkoVnjeo7o6I88izJkCbMqLfarin5bc7yTXVLLWE/wo1AMyX7pKFQwrRvy\n\tLhvjgHpFMadTusZbzzaFYVj3810hLhwpMwLymQFLw67z8Ub3rGy5ltG5kBxfP+rTb0XU\n\tfwAQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736334637; x=1736939437;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=;\n\tb=Hsue7vD4cB0+I3eQZjSEuSCopbYMsS8/4ZDuibCMhvw/5yfiVdBy4CYim7eUjGGOKx\n\tPt0HlYhijWHWbdP2I2di4s3fS5ioNL0hyWi8vNNnHmjSNqxHZTGHEGXex9x56jxYS7GT\n\t3WuXVI3VGYZK5bt+a/7BIF56gGjgKVuqf7JHlT/0ltfMIJLI36bHAvE5LKK0TzlCG0yB\n\txPO7NxWbTNyqFI0iZ3f2rusjhmOwffb5MSA5JYsNIrH92YC+k1DkAPatxh4rVGUMrqsH\n\tyADKCTjlLAid4bowONlWQmaeHYBXViIuhj2YswJ5lETQGzwuEPmfglzXuzH9IHN3RQmK\n\t/0Mg==", "X-Gm-Message-State": "AOJu0Yw/MtqMEKUbrwE6G0rxR633cibvEwYFLP8MiLrtPWo/3bA2VSTF\n\t17GE9077y4NbJd0m/gsUTaLVAWQD0oY/4flIE8S+iFjTPj+aUZTxjntusG8jVbX3NbqJNRHKjGZ\n\tkEhg=", "X-Gm-Gg": "ASbGncu0oBD7jUuQYFScGnJDQ7U4xNvXmvv70HYatpV5dO3K5226YFlby6aAPbmnXBO\n\tcMXUPm4oAvjZhqOt/Yja81PKFNDLGZmW/ehLSgY6H8xz4GOGHYLp9Ik3xfbK/J2O80yvxNuGUXj\n\twciqcBycaRs2FmRDi6K2h+sNrvB9co432BtwyRL4y8lxvZOtT23huStJm5xfnNQlG+GaxISSYVV\n\tTHp3Lyndlsduhg4wusd+MeafVbanlxL8Z83XSxQxAJNQEvEaLcmUk7rlQSZ/SxA3SalEdnH2B1D", "X-Google-Smtp-Source": "AGHT+IEZ8EGlXCHz8Njxi2CDY/KVHhEmhtBs4zXZ8LCn5ZJ1uspM+SwZdj6VFKoNRBwZn461PWHYEQ==", "X-Received": "by 2002:a05:600c:3ca0:b0:436:17f4:9b3b with SMTP id\n\t5b1f17b1804b1-436e270729bmr7513835e9.6.1736334636745; \n\tWed, 08 Jan 2025 03:10:36 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 3/4] ipa: rpi: Add a HW property to determine if the data\n\tbuffer is strided", "Date": "Wed, 8 Jan 2025 11:09:35 +0000", "Message-ID": "<20250108111030.3257931-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250108111030.3257931-1-naush@raspberrypi.com>", "References": "<20250108111030.3257931-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This property (dataBufferStrided) indicates if the CSI-2 hardware writes\nto the embedded/metadata buffer directly, or if it treats the buffer\nlike an image buffer and strides the metadata lines.\n\nUnicam writes this buffer strided, while the PiSP Frontend writes to it\ndirectly. This information will be relevant to data parsers in the\nhelpers where the data is structured in lines.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/controller/controller.cpp | 2 ++\n src/ipa/rpi/controller/controller.h | 1 +\n 2 files changed, 3 insertions(+)", "diff": "diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\nindex e0131018e7b2..651fff632400 100644\n--- a/src/ipa/rpi/controller/controller.cpp\n+++ b/src/ipa/rpi/controller/controller.cpp\n@@ -39,6 +39,7 @@ static const std::map<std::string, Controller::HardwareConfig> HardwareConfigMap\n \t\t\t.pipelineWidth = 13,\n \t\t\t.statsInline = false,\n \t\t\t.minPixelProcessingTime = 0s,\n+\t\t\t.dataBufferStrided = true,\n \t\t}\n \t},\n \t{\n@@ -71,6 +72,7 @@ static const std::map<std::string, Controller::HardwareConfig> HardwareConfigMap\n \t\t\t * frames wider than ~16,000 pixels.\n \t\t\t */\n \t\t\t.minPixelProcessingTime = 1.0us / 380,\n+\t\t\t.dataBufferStrided = false,\n \t\t}\n \t},\n };\ndiff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\nindex eff520bd61de..fdb46557de9c 100644\n--- a/src/ipa/rpi/controller/controller.h\n+++ b/src/ipa/rpi/controller/controller.h\n@@ -49,6 +49,7 @@ public:\n \t\tunsigned int pipelineWidth;\n \t\tbool statsInline;\n \t\tlibcamera::utils::Duration minPixelProcessingTime;\n+\t\tbool dataBufferStrided;\n \t};\n \n \tController();\n", "prefixes": [ "v3", "3/4" ] }