Patch Detail
Show a patch.
GET /api/patches/22454/?format=api
{ "id": 22454, "url": "https://patchwork.libcamera.org/api/patches/22454/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22454/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250106100613.493108-1-pobrn@protonmail.com>", "date": "2025-01-06T10:06:16", "name": "[v3,1/2] gstreamer: allocator: gst_libcamera_allocator_new(): Recognize errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1ac5913b56e47a6ed2412d66d5e85edc233600c", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22454/mbox/", "series": [ { "id": 4930, "url": "https://patchwork.libcamera.org/api/series/4930/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4930", "date": "2025-01-06T10:06:16", "name": "[v3,1/2] gstreamer: allocator: gst_libcamera_allocator_new(): Recognize errors", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4930/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22454/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22454/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CC5AC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jan 2025 10:06:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E500D684E2;\n\tMon, 6 Jan 2025 11:06:22 +0100 (CET)", "from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DCDC608AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jan 2025 11:06:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"dPujPZWa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736157981; x=1736417181;\n\tbh=ePjn5HvU0udlq8bTo7GChoHPsN/azCpmTcbyqXuWdao=;\n\th=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=dPujPZWa++JlH84GQUZpmAul3CL5PoZuSFfRE/CaeZqBHrXWsaNXwle9hn7aMsFSW\n\tehM/xsQNN2C3jGOy4WYWEDcZu2FX0jac+fEz83vHxg0QdagIW+Gzbh7kX/YIli1r7r\n\tH/4+eQz+fyv+6UPbpi7MxLXb+61uYbYv3tP4zmhV9z7NArKcp3ALbIVEwDmBQt6/QL\n\tZllVhUXK52ZSbMEq2AUr1p7sqEdGINUo9JBPZsVbEIO6Pv4dDLBem+hxN/SveRZe40\n\tQ6nrFe0zSYNB8fl8cZ+jzV1hIZ44PxIdDB+7mdp5p8GtK4EaJVGUiPE3wrjmWFpMLD\n\tb5EOoIDkjfeRQ==", "Date": "Mon, 06 Jan 2025 10:06:16 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tNicolas Dufresne <nicolas.dufresne@collabora.com>", "Subject": "[PATCH v3 1/2] gstreamer: allocator: gst_libcamera_allocator_new():\n\tRecognize errors", "Message-ID": "<20250106100613.493108-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "ad987dd89b5e3c22bae226b0d158640cac6a57c6", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`FrameBufferAllocator::allocate()` might return a negative error code,\nbut currently this is handled the same way as success. So instead\nof continuing, abort the construction of the allocator object.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\nChanges in v3: none\nChanges in v2: none\n---\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.47.1", "diff": "diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 7e4c904da..b0c84893a 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr<Camera> camera,\n \t\tStream *stream = streamCfg.stream();\n\n \t\tret = self->fb_allocator->allocate(stream);\n-\t\tif (ret == 0)\n+\t\tif (ret <= 0)\n \t\t\treturn nullptr;\n\n \t\tGQueue *pool = g_queue_new();\n", "prefixes": [ "v3", "1/2" ] }