Patch Detail
Show a patch.
GET /api/patches/22442/?format=api
{ "id": 22442, "url": "https://patchwork.libcamera.org/api/patches/22442/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22442/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241220162724.756494-3-stefan.klug@ideasonboard.com>", "date": "2024-12-20T16:26:48", "name": "[RFC,2/7] libcamera: delayed_controls: Increase log level for dummy pushes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "75b50d2646729c9c135c95e9c9b4a9463197c469", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22442/mbox/", "series": [ { "id": 4925, "url": "https://patchwork.libcamera.org/api/series/4925/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4925", "date": "2024-12-20T16:26:46", "name": "Improve regulation on rkisp1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4925/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22442/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22442/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD124C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Dec 2024 16:27:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C681684BB;\n\tFri, 20 Dec 2024 17:27:36 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C96BD684AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Dec 2024 17:27:32 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4eeb:7fa7:1fd0:c13d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CF1BC67;\n\tFri, 20 Dec 2024 17:26:53 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GQB2V1MQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734712013;\n\tbh=3XmdSfN/v8OjC8PlxJ9vF+iIzbnfS+VhnzlsHUyWUA4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GQB2V1MQEam5ZHu2RQmsTkA5/za+ZUWs7VSYPLY6CVwLjjPMSg5OfCvT8R74CRabb\n\tW3gTH2xr/KsYyYE75Kchmh1Wv+TjWAcRCzogX7pWN51d7vYZwrrimJJtzq16HDlfXG\n\tkzEeAy2Rm8oSBSMyTPotfBZ317PlSrQfm28KfQyg=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[RFC PATCH 2/7] libcamera: delayed_controls: Increase log level for\n\tdummy pushes", "Date": "Fri, 20 Dec 2024 17:26:48 +0100", "Message-ID": "<20241220162724.756494-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241220162724.756494-1-stefan.klug@ideasonboard.com>", "References": "<20241220162724.756494-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When an automatic no-op is queued a debug message is printed. Change the\ndebug level to warning, because that situation is actually an indication\nof something going seriously out of sync.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/delayed_controls.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 6c82d5058ae8..2f134cbe7fdd 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -303,7 +303,7 @@ void DelayedControls::applyControls(uint32_t sequence)\n \twriteCount_ = sequence + 1;\n \n \twhile (writeCount_ > queueCount_) {\n-\t\tLOG(DelayedControls, Debug)\n+\t\tLOG(DelayedControls, Warning)\n \t\t\t<< \"Queue is empty, auto queue no-op.\";\n \t\tpush(queueCount_, {});\n \t}\n", "prefixes": [ "RFC", "2/7" ] }