Patch Detail
Show a patch.
GET /api/patches/22433/?format=api
{ "id": 22433, "url": "https://patchwork.libcamera.org/api/patches/22433/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22433/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241220150759.709756-8-pobrn@protonmail.com>", "date": "2024-12-20T15:08:33", "name": "[RFC,v1,07/12] apps: lc-compliance: Use array instead of `std::vector`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "42d0e5d3fdbd6e4aef4f298cbd8158c000989e68", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22433/mbox/", "series": [ { "id": 4923, "url": "https://patchwork.libcamera.org/api/series/4923/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4923", "date": "2024-12-20T15:08:03", "name": "apps: lc-compliance: Multi-stream tests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4923/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22433/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22433/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C588BC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Dec 2024 15:08:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44E16684B0;\n\tFri, 20 Dec 2024 16:08:41 +0100 (CET)", "from mail-10629.protonmail.ch (mail-10629.protonmail.ch\n\t[79.135.106.29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25088684A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Dec 2024 16:08:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"HgSvzZg9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734707318; x=1734966518;\n\tbh=WKoFjmRvW/VLNW9jHasQCeXJOze+IkFyTDPoeZgW8/U=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=HgSvzZg9ZH4sKuSzstzQ4K7twh54ouE8+iIdMbJfARuV5QGshSb7SnMNI0xRcR3Ny\n\t0QeNNhZTv3a2nn9qUH5Moa2k7yqOaR5i0gGGXBtYxJzktay2AnJpCVhiCEVyxujLHv\n\tPx1jUKiaxyu+/q9sq0wp+Jm/K+QAshLcCe8+hQxLgh6pcbrf8+nP2gVuK6iV3y0toU\n\tjYqNtU5wvNbfZZhxSkNBh5vNsS7RrslvvKPGuLOhdlR/Y4Ae7GpwZbAwIXIXIkk4Yc\n\t4EvWD9duIwOv/EUf56/N1DEVvXhaQE8mbUT99bKnS1o+lXQTOnEJrc8+3OMUjuUaep\n\tpKbsdiXSP8Btw==", "Date": "Fri, 20 Dec 2024 15:08:33 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[RFC PATCH v1 07/12] apps: lc-compliance: Use array instead of\n\t`std::vector`", "Message-ID": "<20241220150759.709756-8-pobrn@protonmail.com>", "In-Reply-To": "<20241220150759.709756-1-pobrn@protonmail.com>", "References": "<20241220150759.709756-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "527a818331aa2e1a317dff3b1b0f48ca59ab86d2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no reason to use `std::vector` for this static\ndata, a simple array will do fine.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/apps/lc-compliance/tests/capture_test.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\nindex db196a949..97465a612 100644\n--- a/src/apps/lc-compliance/tests/capture_test.cpp\n+++ b/src/apps/lc-compliance/tests/capture_test.cpp\n@@ -18,8 +18,9 @@ namespace {\n \n using namespace libcamera;\n \n-const std::vector<int> NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n-const std::vector<StreamRole> ROLES = {\n+const int NUMREQUESTS[] = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n+\n+const StreamRole ROLES[] = {\n \tStreamRole::Raw,\n \tStreamRole::StillCapture,\n \tStreamRole::VideoRecording,\n", "prefixes": [ "RFC", "v1", "07/12" ] }