Patch Detail
Show a patch.
GET /api/patches/22416/?format=api
{ "id": 22416, "url": "https://patchwork.libcamera.org/api/patches/22416/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22416/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241219175729.293782-9-stefan.klug@ideasonboard.com>", "date": "2024-12-19T17:57:25", "name": "[v6,8/9] utils: tuning: rkisp1: Replace static AWB with new AWB module", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d652ac2696cdd615d41b5524b46e654f89bebead", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22416/mbox/", "series": [ { "id": 4919, "url": "https://patchwork.libcamera.org/api/series/4919/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4919", "date": "2024-12-19T17:57:17", "name": "rkisp1: Add manual colour temperature control", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4919/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22416/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22416/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1624BC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Dec 2024 17:58:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50C0768491;\n\tThu, 19 Dec 2024 18:57:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87F496848E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Dec 2024 18:57:55 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:783:85f9:c998:cb11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0600163;\n\tThu, 19 Dec 2024 18:57:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sRsXFU5a\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734631036;\n\tbh=GIDf4SFqGRW15SOHRkYnSYz+H836dVqkFf16SLOo0sE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sRsXFU5astj+lRPYX8LmXrePEkD/nMAhM8LyQAR7MNVkKA2p48xveyrSPRZh0IXzd\n\tampNnx86jvEwgv4rsW4ffrkrJtVqDBPgd2Bw1ofWC3QKbQQGSkgLqdwn7rGF3QdwUX\n\toL3PMci9mrAjHZa33FrLZF9Mv65W4UPqt3PfS+q8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v6 8/9] utils: tuning: rkisp1: Replace static AWB with new\n\tAWB module", "Date": "Thu, 19 Dec 2024 18:57:25 +0100", "Message-ID": "<20241219175729.293782-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241219175729.293782-1-stefan.klug@ideasonboard.com>", "References": "<20241219175729.293782-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The rkisp1 tuner used a static module to insert the AWB algorithm into\nthe tuning file. Replace that with the new AWB module.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/tuning/rkisp1.py | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex f5c42a61d15e..9f40fd8bd63b 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -2,6 +2,7 @@\n # SPDX-License-Identifier: GPL-2.0-or-later\n #\n # Copyright (C) 2022, Paul Elder <paul.elder@ideasonboard.com>\n+# Copyright (C) 2024, Ideas On Board\n #\n # Tuning script for rkisp1\n \n@@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser\n from libtuning.generators import YamlOutput\n from libtuning.modules.lsc import LSCRkISP1\n from libtuning.modules.agc import AGCRkISP1\n+from libtuning.modules.awb import AWBRkISP1\n from libtuning.modules.ccm import CCMRkISP1\n from libtuning.modules.static import StaticModule\n \n coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n \n agc = AGCRkISP1(debug=[lt.Debug.Plot])\n-awb = StaticModule('Awb')\n+awb = AWBRkISP1(debug=[lt.Debug.Plot])\n blc = StaticModule('BlackLevelCorrection')\n ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n color_processing = StaticModule('ColorProcessing')\n", "prefixes": [ "v6", "8/9" ] }