Patch Detail
Show a patch.
GET /api/patches/22385/?format=api
{ "id": 22385, "url": "https://patchwork.libcamera.org/api/patches/22385/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22385/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241217174707.174777-2-pobrn@protonmail.com>", "date": "2024-12-17T17:47:15", "name": "[v2,2/3] libcamera: virtual: Query number of planes correctly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dcab8871b87a346c557fa37cc4f665d8e1a18514", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22385/mbox/", "series": [ { "id": 4907, "url": "https://patchwork.libcamera.org/api/series/4907/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4907", "date": "2024-12-17T17:47:09", "name": "[v2,1/3] libcamera: virtual: Avoid some copies", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4907/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22385/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22385/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38491C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Dec 2024 17:47:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE48268000;\n\tTue, 17 Dec 2024 18:47:23 +0100 (CET)", "from mail-10628.protonmail.ch (mail-10628.protonmail.ch\n\t[79.135.106.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A23D67FF4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Dec 2024 18:47:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"Jhm/TodS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734457640; x=1734716840;\n\tbh=yeWqR3WQB0g1nWWt+Gj1LSg+BkdW2FrSKMmHJ1ogwQ4=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=Jhm/TodSBE+tuRi2ILPrtSjAKAdUznictwMbL05Zs4Y2NuM0ajIv+c3RS8jACBUZX\n\tZdqMoTBL3GYtrQvFMzfAuTnMHtjwyBheQ4lGUfMZ5DrYeUrzjJSi3AMsHJ+oBsj9tg\n\tAwuryY2+gFBJYVhzLaey7oT+GmCtb1MmToOdQICLn0LCgz+bpR4f3ACDCsC10Ck2Pj\n\t1iuvSAitXtOOoKwwDBHkBDq31O6IvqHsfnwsFZ3iLxZT9+EksVvfDkPAPPfDBdmHi/\n\t5kQ1to5XE6t1cYDrGbmiZXw4Z+WuKJVj3ET1vmfsfwaS/poKDBm3SLDCZFhGkTNawS\n\t53uGUhFbuHcnA==", "Date": "Tue, 17 Dec 2024 17:47:15 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 2/3] libcamera: virtual: Query number of planes correctly", "Message-ID": "<20241217174707.174777-2-pobrn@protonmail.com>", "In-Reply-To": "<20241217174707.174777-1-pobrn@protonmail.com>", "References": "<20241217174707.174777-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "1afd3ef31593bf4083c7bcd1318b279c9791a52c", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`PixelFormatInfo::planes.size()` always returns 3 since `planes` is\nan array, but that is not the number of planes of the pixel format.\nUse the `numPlanes()` getter instead.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex ce0c38813..987b192c8 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -277,7 +277,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n \tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n \n \tstd::vector<unsigned int> planeSizes;\n-\tfor (size_t i = 0; i < info.planes.size(); ++i)\n+\tfor (size_t i = 0; i < info.numPlanes(); ++i)\n \t\tplaneSizes.push_back(info.planeSize(config.size, i));\n \n \treturn dmaBufAllocator_.exportBuffers(config.bufferCount, planeSizes, buffers);\n", "prefixes": [ "v2", "2/3" ] }