Patch Detail
Show a patch.
GET /api/patches/22384/?format=api
{ "id": 22384, "url": "https://patchwork.libcamera.org/api/patches/22384/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22384/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241217174707.174777-1-pobrn@protonmail.com>", "date": "2024-12-17T17:47:09", "name": "[v2,1/3] libcamera: virtual: Avoid some copies", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "adaa35b809edf0c67079f01483e777bdb848f499", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22384/mbox/", "series": [ { "id": 4907, "url": "https://patchwork.libcamera.org/api/series/4907/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4907", "date": "2024-12-17T17:47:09", "name": "[v2,1/3] libcamera: virtual: Avoid some copies", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4907/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22384/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22384/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90882C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Dec 2024 17:47:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC21C67FFB;\n\tTue, 17 Dec 2024 18:47:18 +0100 (CET)", "from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E096A67FD3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Dec 2024 18:47:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"gshkXtYZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734457636; x=1734716836;\n\tbh=pLditt3JNEejQpDLu7LxfIdnWqJm03YZUdqiX/aRgmY=;\n\th=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=gshkXtYZFGowEugyvhAHZtM7O7JXFgqZEICuzBvtUfH/KgwYjmUSVj9xz3BfdVvx2\n\tHk0aLg5l70jiQVQUVXYEfStx1wzmVsCGktD5Acj2M/mBqHyCEeH5ZizfizaIO0qZvu\n\ti8Mie8gJ/OLT01vCEHEsG3xJgSCKhx72BxYdMDRq3tzaDX6XsC27rv9vnKk61AYtsw\n\tw2olcXwPFg6eB1LQx2j7iSMIj+oFjJdkN6EF8a1J/fC/2qOoAzfrkgwHoIq/d5UXFS\n\tYhur+tHZqb86lbccRCocHVRZK62x/avyxOzPITzFlBABEs0696ajX9QiL+5N+8ADNe\n\tJ811FNv9G3JJg==", "Date": "Tue, 17 Dec 2024 17:47:09 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 1/3] libcamera: virtual: Avoid some copies", "Message-ID": "<20241217174707.174777-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "a418a188be5d07292092fcf2f7f2726942aa7e10", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no reason make copies, these functions return\nconst lvalue references, access the data through those.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/virtual/image_frame_generator.cpp | 2 +-\n src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 2 +-\n src/libcamera/pipeline/virtual/virtual.cpp | 3 +--\n 3 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\nindex 277efbb09..d1545b5d9 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n@@ -129,7 +129,7 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n \n \tMappedFrameBuffer mappedFrameBuffer(buffer, MappedFrameBuffer::MapFlag::Write);\n \n-\tauto planes = mappedFrameBuffer.planes();\n+\tconst auto &planes = mappedFrameBuffer.planes();\n \n \t/* Loop only around the number of images available */\n \tframeIndex_ %= imageFrameDatas_.size();\ndiff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\nindex 7bc2b338c..47d341919 100644\n--- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n@@ -25,7 +25,7 @@ int TestPatternGenerator::generateFrame(const Size &size,\n \tMappedFrameBuffer mappedFrameBuffer(buffer,\n \t\t\t\t\t MappedFrameBuffer::MapFlag::Write);\n \n-\tauto planes = mappedFrameBuffer.planes();\n+\tconst auto &planes = mappedFrameBuffer.planes();\n \n \tshiftLeft(size);\n \ndiff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex a44f286b7..ce0c38813 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -274,8 +274,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n \t\treturn -ENOBUFS;\n \n \tconst StreamConfiguration &config = stream->configuration();\n-\n-\tauto info = PixelFormatInfo::info(config.pixelFormat);\n+\tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n \n \tstd::vector<unsigned int> planeSizes;\n \tfor (size_t i = 0; i < info.planes.size(); ++i)\n", "prefixes": [ "v2", "1/3" ] }