Patch Detail
Show a patch.
GET /api/patches/22339/?format=api
{ "id": 22339, "url": "https://patchwork.libcamera.org/api/patches/22339/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22339/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241216043954.3506855-9-paul.elder@ideasonboard.com>", "date": "2024-12-16T04:39:54", "name": "[v5,8/8] controls: Remove AeEnable and AeLocked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2ff36d591a6f5814c5ba3471f7a1f0d0ad78d59d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22339/mbox/", "series": [ { "id": 4892, "url": "https://patchwork.libcamera.org/api/series/4892/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4892", "date": "2024-12-16T04:39:46", "name": "AEGC controls", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4892/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22339/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22339/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 455CEC32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Dec 2024 04:40:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F09367F50;\n\tMon, 16 Dec 2024 05:40:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB6F67F4B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Dec 2024 05:40:34 +0100 (CET)", "from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:c11a:e451:861f:3d32])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6350675;\n\tMon, 16 Dec 2024 05:39:56 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WK203Yj8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734323998;\n\tbh=Pqqtjsqn0Nl8EHZteBA0g+5bMDkTfvql38K9NwhR3ZY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WK203Yj8Kqv28lSzn0HRj4hZn+kHrZWd8Xu+aBSBcmRNMuMpBykRTdb9jBIyfDaDn\n\tx8RP40DS4z0xOg0tEy1rf1Uh+34sgTe0TM9AOg6pzyZN6wCqN0w+Xs+QmgVb6Qg1lo\n\tad1GSU3muYynXCWLUatlzTFTlbA2sFQdN9lk2rSo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo@jmondi.org>,\n\tPaul Elder <paul.elder@ideasonboard.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v5 8/8] controls: Remove AeEnable and AeLocked", "Date": "Mon, 16 Dec 2024 13:39:54 +0900", "Message-Id": "<20241216043954.3506855-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20241216043954.3506855-1-paul.elder@ideasonboard.com>", "References": "<20241216043954.3506855-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nNow that the codebase has been ported to use the new AEGC controls\nremove the definition of AeEnable and AeLocked.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v5\n\nNo change in v4\n\nNo change in v3\n---\n src/libcamera/control_ids_core.yaml | 18 ------------------\n 1 file changed, 18 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex a64d567791c3..d2189feaab9e 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -8,24 +8,6 @@\n # set through Request::controls() and returned out through Request::metadata().\n vendor: libcamera\n controls:\n- - AeEnable:\n- type: bool\n- description: |\n- Enable or disable the AE.\n-\n- \\sa ExposureTime AnalogueGain\n-\n- - AeLocked:\n- type: bool\n- description: |\n- Report the lock status of a running AE algorithm.\n-\n- If the AE algorithm is locked the value shall be set to true, if it's\n- converging it shall be set to false. If the AE algorithm is not\n- running the control shall not be present in the metadata control list.\n-\n- \\sa AeEnable\n-\n - AeState:\n type: int32_t\n description: |\n", "prefixes": [ "v5", "8/8" ] }