Patch Detail
Show a patch.
GET /api/patches/2232/?format=api
{ "id": 2232, "url": "https://patchwork.libcamera.org/api/patches/2232/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2232/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191027203335.26888-2-jacopo@jmondi.org>", "date": "2019-10-27T20:33:30", "name": "[libcamera-devel,1/6] libcamera: object: Define message invocation type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b909c9f6472c3b945db465c30836e27da8d5692b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/2232/mbox/", "series": [ { "id": 558, "url": "https://patchwork.libcamera.org/api/series/558/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=558", "date": "2019-10-27T20:33:29", "name": "Add support for blocking method invocation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/558/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2232/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2232/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FDCD6017A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Oct 2019 21:31:48 +0100 (CET)", "from uno.localdomain (143.121.2.93.rev.sfr.net [93.2.121.143])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 456EEC0005;\n\tSun, 27 Oct 2019 20:31:48 +0000 (UTC)" ], "X-Originating-IP": "93.2.121.143", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 27 Oct 2019 21:33:30 +0100", "Message-Id": "<20191027203335.26888-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191027203335.26888-1-jacopo@jmondi.org>", "References": "<20191027203335.26888-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/6] libcamera: object: Define message\n\tinvocation type", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 27 Oct 2019 20:31:48 -0000" }, "content": "Define an enumeration of invocation types to be used to describe the\ndelivery method of messages through the Object::invokeMethod operation.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/object.h | 7 +++++++\n src/libcamera/object.cpp | 27 +++++++++++++++++++++++++++\n 2 files changed, 34 insertions(+)", "diff": "diff --git a/include/libcamera/object.h b/include/libcamera/object.h\nindex 3308330af857..017d3f8aa915 100644\n--- a/include/libcamera/object.h\n+++ b/include/libcamera/object.h\n@@ -21,6 +21,13 @@ class Signal;\n class SignalBase;\n class Thread;\n \n+enum InvocationType {\n+\tInvocationTypeAuto,\n+\tInvocationTypeDirect,\n+\tInvocationTypeQueued,\n+\tInvocationTypeBlocking,\n+};\n+\n class Object\n {\n public:\ndiff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\nindex 98aa0af2f9b9..82df3893d052 100644\n--- a/src/libcamera/object.cpp\n+++ b/src/libcamera/object.cpp\n@@ -25,6 +25,33 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Object)\n \n+/**\n+ * \\enum InvocationType\n+ * \\brief Method invocation type\n+ *\n+ * This enumeration describes the possible methods invocation types\n+ * that can be used to invoke methods on an Object running in a different\n+ * execution context.\n+ *\n+ * Method invocation is performed by appending an InvokeMessage message to the\n+ * receiver's message queue. This enumeration defines how the caller behaves\n+ * once the message has been delivered to the receiver's queue.\n+ *\n+ * \\var InvocationType::InvocationTypeAuto\n+ * \\brief === I'm not sure how we would use this for method invocation ===\n+ *\n+ * \\var InvocationType::InvocationTypeDirect\n+ * \\brief === I'm not sure how we would use this for method invocation ===\n+ *\n+ * \\var InvocationType::InvocationTypeQueued\n+ * \\brief The method is invoked on the Object and the caller immediately returns\n+ * as soon as the message is queued to the receiver's message queue\n+ *\n+ * \\var InvocationType::InvocationTypeBlocking\n+ * \\brief The method is invoked on the Object and the caller is blocked until\n+ * the called method is not executed\n+ */\n+\n /**\n * \\class Object\n * \\brief Base object to support automatic signal disconnection\n", "prefixes": [ "libcamera-devel", "1/6" ] }