Patch Detail
Show a patch.
GET /api/patches/22319/?format=api
{ "id": 22319, "url": "https://patchwork.libcamera.org/api/patches/22319/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22319/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241215223947.7779-1-laurent.pinchart@ideasonboard.com>", "date": "2024-12-15T22:39:47", "name": "libcamera: yaml_parser: Improve efficiency of string empty check", "commit_ref": "a7aab7da8a716299661b5f451366fb6e2f3d88b2", "pull_url": null, "state": "accepted", "archived": false, "hash": "4a3c9ac0cfc8fa42191053a260549ca8d47ac60b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22319/mbox/", "series": [ { "id": 4888, "url": "https://patchwork.libcamera.org/api/series/4888/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4888", "date": "2024-12-15T22:39:47", "name": "libcamera: yaml_parser: Improve efficiency of string empty check", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4888/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22319/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22319/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0BE8C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 15 Dec 2024 22:40:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1B3567F27;\n\tSun, 15 Dec 2024 23:40:05 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7231A67F1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Dec 2024 23:40:04 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27ED17E9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Dec 2024 23:39:28 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HJPCFXlB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734302368;\n\tbh=pMvf5r8vkkPCU5ke1SSwMiBRVTtKplnaEa3NLi+Ig9s=;\n\th=From:To:Subject:Date:From;\n\tb=HJPCFXlBa6txo5r86sOgxGR3aO8z5V4AyzFTpzADKkJo25HHLUnCSMGTDtMCCBj1o\n\tKVaW/NblckaTphJsI60E+fGrFLwUx7EZLoHFmEkiSe6CLoFAqjSvGgemP4ngltdpqC\n\tQs7c7PEEWlpXNBJi4x6bpYiVfBofi8v4ibEJtwg0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] libcamera: yaml_parser: Improve efficiency of string empty\n\tcheck", "Date": "Mon, 16 Dec 2024 00:39:47 +0200", "Message-ID": "<20241215223947.7779-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Comparing a std::string to an empty string literal is more complex than\nusing the std::string::empty() function. Improve the code efficiency by\nreplacing the former with the latter.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 8e15010b7dfa9c2a68dd57f924b5603784be0e09", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex 5ca5fb8235b5e761..a5e424615c263f2d 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -194,7 +194,7 @@ YamlObject::Getter<double>::get(const YamlObject &obj) const\n \tif (obj.type_ != Type::Value)\n \t\treturn std::nullopt;\n \n-\tif (obj.value_ == \"\")\n+\tif (obj.value_.empty())\n \t\treturn std::nullopt;\n \n \tchar *end;\n", "prefixes": [] }